Refactor Main File

[janikwitzig]

This PR aims to evenutally clean up the main file by separating responsibility into distinct objects.

[janikwitzig]

@elliotmatson this is what I hinted at in #148. Not having a desk currently, I was unable to verify that this actually works.

[elliotmatson]

@janikwitzig I should be able to take a look at all these PR's later this week!

[janikwitzig]

@elliotmatson I rebased this PR onto the main branch and created a handler for the OSC forwarding

When this is merged into the main branch, I'd love to try out the Beta Release feature of Companion. I know a few people who would gladly be beta-testers for this

[elliotmatson]

Ok great! I've been working through these, I'm working on the CC surfaces currently. Is there a suggested merge order for these?

[janikwitzig]

@elliotmatson we should merge this PR first. Since it touches many files the rebases are a good bit of work otherwise. The adjustments to the open PRs will be relatively minor.

[elliotmatson]

This seems like it's in a good spot, what all have you tested so far? I can test things as needed

[janikwitzig]

I was able to test the 'Set Level' and 'Adjust Level' action before getting caught up in a mean bug that is now fixed. I also checked on some feedbacks without much of a system, just to see if it works. Variables work as well

[elliotmatson]

Ok, I can start working through the actions. Do we want to round any floating point variables to the nearest 0.1 dB? That seems to be what the wing does internally, and I'm assuming that people don't want a billion decimal places of precision.

It would be simple to do in the this.variableHandler.on('update-variable', (variable, value) handler, do you think we would need to check the delta from the original value so that small changes aren't constantly hitting the rate limiter?

[janikwitzig]

Rounding sounds great. To keep the main file clean I'd probably opt to doing the rounding in the variable-handler file itself only for the variables that we want this. This would keep the main file clean and prevent accidental rounding of values we potentially don't want to round.

[janikwitzig]

Check 2384f35. Can't test right now, but I hope this works

[janikwitzig]

@elliotmatson Your suggestion of rounding the variables is now implemented. I checked every action except for the card (don't have one), and everything is fine. Two minor issues popped up, but those had to do with the original implementation rather than the refactoring.

I would happily proceed to merge this into main. Should we do a release of the current main and try to release these changes as Beta?

[elliotmatson]

I've been testing as well, and seems to be working!

Do you mean release the current main as stable, merge, then release a beta?

[janikwitzig]

Yes exactly 👍

[elliotmatson]

I'm great with that!

[janikwitzig]

@elliotmatson If you agree, I would proceed to merge this into main and release it as a beta