Skip to content

Conversation

@gbubemismith
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-20283

📔 Objective

If a user doesn't have access to the at-risk password screen, the browser extension prompt launches a blank at-risk password screen in the browser extension

📸 Screenshots

Screen.Recording.2025-05-05.at.13.22.19.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@gbubemismith gbubemismith requested a review from a team as a code owner May 5, 2025 17:26
@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 36.39%. Comparing base (c61bb3d) to head (5ab41f5).
Report is 103 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rowser/src/vault/guards/at-risk-passwords.guard.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14633      +/-   ##
==========================================
- Coverage   36.39%   36.39%   -0.01%     
==========================================
  Files        3193     3193              
  Lines       92597    92601       +4     
  Branches    16662    16662              
==========================================
  Hits        33698    33698              
- Misses      56476    56480       +4     
  Partials     2423     2423              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2025

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Logo
Checkmarx One – Scan Summary & Details809d1ff3-4555-4d59-a399-a169f3fdb92b

Great job, no security vulnerabilities found in this Pull Request

@gbubemismith gbubemismith merged commit 0750ff3 into main May 13, 2025
46 checks passed
@gbubemismith gbubemismith deleted the vault/PM-20283 branch May 13, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants