Skip to content

PM-21318 Org member with Manage collection permission getting error when saving item to org collection #14670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dan-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-21318

📔 Objective

Avoid passing default string literal in folder

📸 Screenshots

Screen.Recording.2025-05-07.at.3.45.12.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@dan-livefront dan-livefront self-assigned this May 7, 2025
Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.23%. Comparing base (74b6bb1) to head (3caaa24).
Report is 23 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/browser/src/autofill/notification/bar.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14670      +/-   ##
==========================================
- Coverage   36.24%   36.23%   -0.01%     
==========================================
  Files        3191     3191              
  Lines       92281    92282       +1     
  Branches    16555    16556       +1     
==========================================
- Hits        33443    33436       -7     
- Misses      56452    56460       +8     
  Partials     2386     2386              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 7, 2025

Logo
Checkmarx One – Scan Summary & Details609afef7-cac8-4516-8f62-904cb4db7de3

Great job, no security vulnerabilities found in this Pull Request

@dan-livefront dan-livefront marked this pull request as ready for review May 7, 2025 20:06
@dan-livefront dan-livefront requested a review from a team as a code owner May 7, 2025 20:06
jprusik
jprusik previously approved these changes May 7, 2025
Copy link

sonarqubecloud bot commented May 7, 2025

@jprusik jprusik merged commit 00a37d9 into main May 8, 2025
45 checks passed
@jprusik jprusik deleted the PM-21318-defect-org-member-with-manage-collection-permission-getting-error-when-saving-item-to-org-collection branch May 8, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants