[PM-29513] Remove @ts-strict-ignore in fido2/content/fido2-content-script.ts

[dan-livefront]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29513

📔 Objective

I made the abortController within handleFido2Message an optional param in order to match the Handler. I could have made the Handler require the abortController but other call sites didn't use the abortController or had it as optional making me default to match the other patterns

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – aaff2487-8353-45bd-a0ea-264de55adbc9

Great job! No new security vulnerabilities introduced in this pull request

[claude]

Claude finished @dan-livefront's task in 1m 56s —— View job

---

Overall Assessment: APPROVE ✅

This PR successfully removes the @ts-strict-ignore directive by making the abortController parameter optional to match the Handler interface definition. The implementation correctly uses optional chaining for all abortController accesses, maintaining type safety without changing runtime behavior.

Code Review Details

No issues found. The changes are correct and well-tested:

• Type signature now matches the Handler interface (messenger.ts:17-20)
• Optional chaining properly handles the optional parameter
• All existing tests pass, covering the primary use case where abortController is always provided by the messenger
• Change is backward compatible and improves type safety

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.24%. Comparing base (ccb9a0b) to head (cb90d6b).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...src/autofill/fido2/content/fido2-content-script.ts	0.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #18143      +/-   ##
==========================================
- Coverage   42.25%   42.24%   -0.01%     
==========================================
  Files        3593     3593              
  Lines      104381   104381              
  Branches    15738    15740       +2     
==========================================
- Hits        44103    44099       -4     
- Misses      58403    58406       +3     
- Partials     1875     1876       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bw-ghapp]

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

[bw-ghapp]

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉