Skip to content

[PM-29513] Remove @ts-strict-ignore in fido2/content/fido2-content-script.ts #18143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dan-livefront wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −5
Open

[PM-29513] Remove @ts-strict-ignore in fido2/content/fido2-content-script.ts #18143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
313e639
make abortController optional to match the handler
dan-livefront Dec 29, 2025
cb90d6b
Merge branch 'main' into PM-29513-lo-impact-remove-ts-strict-ignore-i…
dan-livefront Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions apps/browser/src/autofill/fido2/content/fido2-content-script.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// FIXME: Update this file to be type safe and remove this and next line
// @ts-strict-ignore
import {
AssertCredentialParams,
CreateCredentialParams,
Expand Down Expand Up @@ -41,12 +39,12 @@ import { MessageWithMetadata, Messenger } from "./messaging/messenger";
*/
async function handleFido2Message(
message: MessageWithMetadata,
abortController: AbortController,
abortController?: AbortController,
) {
const requestId = Date.now().toString();
const abortHandler = () =>
sendExtensionMessage("fido2AbortRequest", { abortedRequestId: requestId });
abortController.signal.addEventListener("abort", abortHandler);
abortController?.signal.addEventListener("abort", abortHandler);

try {
if (message.type === MessageTypes.CredentialCreationRequest) {
Expand All @@ -67,7 +65,7 @@ import { MessageWithMetadata, Messenger } from "./messaging/messenger";
return sendExtensionMessage("fido2AbortRequest", { abortedRequestId: requestId });
}
} finally {
abortController.signal.removeEventListener("abort", abortHandler);
abortController?.signal.removeEventListener("abort", abortHandler);
}
}

Expand Down
Loading