[PM-36839] Merge API errors

[dani-garcia]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-36839

📔 Objective

Remove the API error from bitwarden-core and reexport the one from bitwarden-api-base instead, which is now identical. We can also finally remove the unused generic type parameter in Error.

This change will save every user of the API bindings from having to do a manual .map_err() or impl<T> From<bitwarden_api_api::apis::Error<T>> every time they interact with an API error.

🚨 Breaking Changes

[github-actions]

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR unifies bitwarden_core::ApiError with bitwarden_api_base::Error by re-exporting the latter, removes the unused T generic parameter (and its _Phantom uninhabited placeholder), and drops the boilerplate impl<T> From<bitwarden_api_api::apis::Error<T>> and .map_err(ApiError::from)? patterns at ~25 call sites. The change is a clean deduplication: since bitwarden_api_api::apis::Error is pub use bitwarden_api_base::*, the types are now literally identical, so downstream #[from] ApiError impls (via thiserror) propagate via ? directly. UniFFI consumers remain unaffected (uniffi(flat_error) is preserved) and the existing pattern-matching tests on ApiError::Response(ResponseContent { ... }) continue to compile because variant structure is unchanged.

Code Review Details

No findings.

[github-actions]

🔍 SDK Breaking Change Detection

SDK Version: ps/PM-36839-merge-api-errors (3dbb193)

⚠️ If breaking changes are detected, a corresponding pull request addressing them must be ready for merge in the affected client repository.

Client	Status	Details
typescript	✅ No breaking changes detected	Compilation passed with new SDK version - View Details
android	✅ No breaking changes detected	Compilation passed with new SDK version - View Details

---

Breaking change detection uses the build of the SDK from this branch, including any incompatibities pre-existing on or merged into this branch. Check the workflow logs to confirm.
Results update as workflows complete.

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.17%. Comparing base (d2118d2) to head (19de958).

Files with missing lines	Patch %	Lines
...ates/bitwarden-core/src/auth/login/auth_request.rs	0.00%	2 Missing ⚠️
crates/bitwarden-core/src/auth/login/prelogin.rs	0.00%	1 Missing ⚠️
crates/bitwarden-core/src/auth/login/two_factor.rs	0.00%	1 Missing ⚠️
...es/bitwarden-core/src/platform/get_user_api_key.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
+ Coverage   84.12%   84.17%   +0.05%     
==========================================
  Files         446      445       -1     
  Lines       58817    58725      -92     
==========================================
- Hits        49478    49434      -44     
+ Misses       9339     9291      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
9.3% Duplication on New Code

See analysis details on SonarQube Cloud

[harr1424]

Tools owned changes to Sends look good!