Added how to connect in a reverse way and/or via a repeater #274
Conversation
bk138
left a comment
bk138
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Minor nitpicks!
README.md
Outdated
|
|
||
| #### Direct VNC | ||
| If you prefer automatically accepting connections from outside: | ||
| 1. You should allow [Port Forwarding](https://en.wikipedia.org/wiki/Port_forwarding) in your router's Firewall settings. Either use [UPnP](https://en.wikipedia.org/wiki/Universal_Plug_and_Play) or log in to your router's settings (usually open 192.168.1.1 in your browser, some routers have password written on them). |
There was a problem hiding this comment.
The app does not do UPnP so this should not be mentioned :-)
There was a problem hiding this comment.
I've rephrased, please re-consider.
README.md
Outdated
| Leaving ports always open is considered risky, and either way most users don't even know how to open them in their routers. You can thus leave the VNC port **blank** and instead connect to either a **listening viewer** or a **repeater**: | ||
|
|
||
| 1. You should allow [Port Forwarding](https://en.wikipedia.org/wiki/Port_forwarding) in your router's Firewall settings. Login to your router's settings (usually open 192.168.1.1 in your browser, some routers have password written on them). | ||
|  |
There was a problem hiding this comment.
please remove that link as it might go dead if you remove your fork :-)
There was a problem hiding this comment.
The URL structure user-attachments/assets/ suggests the attachment is associated with a GitHub user account, not a specific repository, issue, pull request, etc. or in this case fork.
So I assume the only chance it'll get deleted is if my entire username gets deleted, which is far less common than a fork deletion. But...GitHub in known in general for never deleting attachments under any circumstances. Not enough? Then I've just created a new account, took a screenshot of this PR, then deleted the entire username. And guess what? The screenshot still remains.
Nevertheless, to cover it 100%, I've just asked officially about it and used references and the aforementioned proof of concept.
But if despite all this you're still worried, you can download and then re-upload the attachment into this pull request's code, so it'll be linked to your username. But then again, what happens if one day you decide to let someone else be admin and delete your username? ;-) This is exactly why I think GitHub never deletes attachments.
There was a problem hiding this comment.
I prefer to not have a detailed discussion about this. The repo should be self-contained. Please just remove the link :-)
README.md
Outdated
| Leaving ports always open is considered risky, and either way most users don't even know how to open them in their routers. You can thus leave the VNC port **blank** and instead connect to either a **listening viewer** or a **repeater**: | ||
|
|
||
| 1. You should allow [Port Forwarding](https://en.wikipedia.org/wiki/Port_forwarding) in your router's Firewall settings. Login to your router's settings (usually open 192.168.1.1 in your browser, some routers have password written on them). | ||
|  |
README.md
Outdated
| Leaving ports always open is considered risky, and either way most users don't even know how to open them in their routers. You can thus leave the VNC port **blank** and instead connect to either a **listening viewer** or a **repeater**: | ||
|
|
||
| 1. You should allow [Port Forwarding](https://en.wikipedia.org/wiki/Port_forwarding) in your router's Firewall settings. Login to your router's settings (usually open 192.168.1.1 in your browser, some routers have password written on them). | ||
|  |
There was a problem hiding this comment.
I prefer to not have a detailed discussion about this. The repo should be self-contained. Please just remove the link :-)
2 participants
Also mentioned UPnP as an alternative to opening ports manually.