-
-
Notifications
You must be signed in to change notification settings - Fork 280
Added how to connect in a reverse way and/or via a repeater #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove that link as it might go dead if you remove your fork :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL structure
user-attachments/assets/suggests the attachment is associated with a GitHub user account, not a specific repository, issue, pull request, etc. or in this case fork.So I assume the only chance it'll get deleted is if my entire username gets deleted, which is far less common than a fork deletion. But...GitHub in known in general for never deleting attachments under any circumstances. Not enough? Then I've just created a new account, took a screenshot of this PR, then deleted the entire username. And guess what? The screenshot still remains.
Nevertheless, to cover it 100%, I've just asked officially about it and used references and the aforementioned proof of concept.
But if despite all this you're still worried, you can download and then re-upload the attachment into this pull request's code, so it'll be linked to your username. But then again, what happens if one day you decide to let someone else be admin and delete your username? ;-) This is exactly why I think GitHub never deletes attachments.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to not have a detailed discussion about this. The repo should be self-contained. Please just remove the link :-)