fix(rsky-pds): clone exact PR commit so new workspace members are included#189
Open
afbase wants to merge 4 commits into
Open
fix(rsky-pds): clone exact PR commit so new workspace members are included#189afbase wants to merge 4 commits into
afbase wants to merge 4 commits into
Conversation
…embers are present The docker build was cloning origin/main, which does not include crates added in an open PR (e.g. rsky-graph). Pass COMMIT_SHA as a build-arg and use git init/fetch/checkout to check out the exact commit under test, ensuring the workspace Cargo.toml and all member crates are consistent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 tasks
The previous sed range '/\[workspace\]/,/\[/p' stopped at the first line containing '[' after [workspace], which is 'members = [' itself. MEMBERS_SECTION ended up as just that one line (no quoted names), so readarray produced [""], and any PR touching .github/ would pass an empty package name to cargo check/build. Switch to a range that spans from 'members = [' through the closing ']' so all member names are captured regardless of workspace size. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…/format_commit rsky-repo changed these signatures to take &Keypair; remove the stray dereferences in actor_store so the types match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… test initializers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git clone --depth 1 ... mainwithARG COMMIT_SHA+git init/fetch/checkout FETCH_HEADso the Docker build always clones the exact commit under testCOMMIT_SHA=${{ github.event.pull_request.head.sha || github.sha }}as a build-arg in both the fork and non-fork build steps inrust.ymlWhy
When a PR adds a new workspace member (e.g.
rsky-graph), the old approach clonedorigin/main, which doesn't have that member yet. Cargo then failed to resolve the workspace becauseCargo.tomlreferenced a crate directory that didn't exist. Cloning the specific PR commit ensures the workspace is self-consistent.Test plan
docker-build (rsky-pds)job on PR rsky-graph: incremental periodic save + drop eager bloom rebuild #187 — should resolve thecargo buildexit code 101 failureCOMMIT_SHAarg falls back gracefully tomainfor manual/local builds (no arg passed)🤖 Generated with Claude Code