-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add zones friend name #20761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add zones friend name #20761
Conversation
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for this PR. A few things:
|
Fixed! Thanks for your review. |
|
|
||
| // add default points order for already completed polygons | ||
| if (!activePolygon.pointsOrder && activePolygon.isFinished) { | ||
| if (!activePolygon?.pointsOrder && activePolygon?.isFinished) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you seeing crashes here? Why was this change necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you seeing crashes here? Why was this change necessary?
yup, crashes may occur after saving, but the cause remains unknown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've never had reports of crashes here. It would be good to make sure your changes are not causing an issue.
|
Thanks for the changes. I was suggesting that you update |
Co-authored-by: Josh Hawkins <[email protected]>
Added optional friendly name for zones in configuration.
Proposed change
Add zones friend name
Type of change
Additional information
Checklist
enlocale.ruff format frigate)