Skip to content

Add zones friend name #20761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
+248 −92
Open

Add zones friend name #20761

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2339b5f
feat: add zones friendly name
ZhaiSoul Nov 2, 2025
894f9d0
fix: fix the issue where the input field was empty when there was no …
ZhaiSoul Nov 4, 2025
136836f
chore: fix the issue where the friendly name would replace spaces wit…
ZhaiSoul Nov 4, 2025
b68ddc3
docs: update zones docs
ZhaiSoul Nov 4, 2025
3af47d6
Update web/src/components/settings/ZoneEditPane.tsx
ZhaiSoul Nov 4, 2025
303ebff
Add friendly_name option for zone configuration
ZhaiSoul Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web/src/components/settings/PolygonCanvas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ export function PolygonCanvas({
const activePolygon = updatedPolygons[activePolygonIndex];

// add default points order for already completed polygons
if (!activePolygon.pointsOrder && activePolygon.isFinished) {
if (!activePolygon?.pointsOrder && activePolygon?.isFinished) {
Copy link
Collaborator

@hawkeye217 hawkeye217 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you seeing crashes here? Why was this change necessary?

Copy link
Contributor Author

@ZhaiSoul ZhaiSoul Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you seeing crashes here? Why was this change necessary?

yup, crashes may occur after saving, but the cause remains unknown.

Copy link
Collaborator

@hawkeye217 hawkeye217 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've never had reports of crashes here. It would be good to make sure your changes are not causing an issue.

updatedPolygons[activePolygonIndex] = {
...activePolygon,
pointsOrder: activePolygon.points.map((_, index) => index),
Expand Down
2 changes: 1 addition & 1 deletion web/src/components/settings/ZoneEditPane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ export default function ZoneEditPane({
mode: "onBlur",
defaultValues: {
name: polygon?.name ?? "",
friendly_name: polygon?.friendly_name ?? "",
friendly_name: polygon?.friendly_name ?? polygon?.name,
inertia:
polygon?.camera &&
polygon?.name &&
Expand Down