Fix GEFS chem.5 URL and FastHerbie warning denominator - #530
Merged
Conversation
jacob1299
marked this pull request as ready for review
April 17, 2026 23:12
blaylockbk
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chem.5resolving to the 0.25° bucket path — now points tochem/pgrb2ap5/... a3d_0p50.f{fxx}.grib2FastHerbie"Could not find X/Y GRIB files" warning: denominator waslen(file_exists)instead of totalchem.5URL constructionFixes #516
Fixes #523
Test plan
pytest tests/test_gefs.py— passes (incl. newtest_gefs_chem5_uses_half_degree_path)chem.5URL resolves to a real file on S3 (HEAD 200)chem.25path is unchanged