Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/herbie/fast.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ def __init__(

if len(self.file_not_exists) > 0:
log.warning(
f"Could not find {len(self.file_not_exists)}/{len(self.file_exists)} GRIB files."
f"Could not find {len(self.file_not_exists)}/{len(self.file_not_exists) + len(self.file_exists)} GRIB files."
)

def __len__(self) -> int:
Expand Down
2 changes: 1 addition & 1 deletion src/herbie/models/gefs.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def template(self):
"atmos.5b": f"{filedir}/atmos/pgrb2bp5/ge{self.member}.t{self.date:%H}z.pgrb2b.0p50.f{self.fxx:03d}",
"atmos.25": f"{filedir}/atmos/pgrb2sp25/ge{self.member}.t{self.date:%H}z.pgrb2s.0p25.f{self.fxx:03d}",
"wave": f"{filedir}/wave/gridded/gefs.wave.t{self.date:%H}z.{self.member}.global.0p25.f{self.fxx:03d}.grib2",
"chem.5": f"{filedir}/chem/pgrb2ap25/gefs.chem.t{self.date:%H}z.a2d_0p25.f{self.fxx:03d}.grib2",
"chem.5": f"{filedir}/chem/pgrb2ap5/gefs.chem.t{self.date:%H}z.a3d_0p50.f{self.fxx:03d}.grib2",
"chem.25": f"{filedir}/chem/pgrb2ap25/gefs.chem.t{self.date:%H}z.a2d_0p25.f{self.fxx:03d}.grib2",
}

Expand Down
14 changes: 14 additions & 0 deletions tests/test_gefs.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,17 @@ def test_gefs_reforecast():

assert H.grib, "GEFS grib2 file not found"
assert H.idx, "GEFS index file not found"


def test_gefs_chem5_uses_half_degree_path():
"""chem.5 must resolve to the 0.5° bucket path, not the 0.25° one."""
H = Herbie(
"2023-06-08 00:00",
model="gefs",
product="chem.5",
member="c00",
fxx=3,
save_dir=save_dir,
)
assert "pgrb2ap5" in H.SOURCES["aws"]
assert "a3d_0p50" in H.SOURCES["aws"]
Loading