Replace btc and usd names sanity check#3621
Conversation
Co-authored-by: grimen <4783+grimen@users.noreply.github.com>
Co-authored-by: grimen <4783+grimen@users.noreply.github.com>
Co-authored-by: grimen <4783+grimen@users.noreply.github.com>
Changes shouldnt apply to amounts ex "0.00000001 BTC"
or currencies 1 BTC = {btcToUsdRate}
Rest of the renaming seems correct to me
There was a problem hiding this comment.
Pull request overview
This PR updates user-facing currency wording across the app, replacing “BTC”/“USD” labels with “Bitcoin”/“Dollar” (and “US Dollar” in one educational string) to better match product terminology.
Changes:
- Updated various UI labels from “BTC”/“USD” to “Bitcoin”/“Dollar”.
- Updated multiple English i18n strings to replace “BTC”/“USD” phrasing.
- Adjusted some labels to remove explicit “USD” references (e.g., daily limit, dev price label).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| app/screens/redeem-lnurl-withdrawal-screen/redeem-bitcoin-detail-screen.tsx | Updates currency tab labels from abbreviations to full names. |
| app/screens/developer-screen/developer-screen.tsx | Tweaks developer price label text (drops “USD” wording). |
| app/i18n/raw-i18n/source/en.json | Updates English source strings for “BTC/USD” naming and some related copy. |
| app/i18n/i18n-types.ts | Updates generated i18n types to reflect new English strings. |
| app/i18n/en/index.ts | Updates compiled English translations for the same wording changes. |
| app/components/wallet-summary/wallet-summary.stories.tsx | Updates Storybook wrapper labels to match new currency naming. |
| app/components/atomic/galoy-currency-bubble-text/galoy-currency-bubble-text.tsx | Updates currency bubble text constants from abbreviations to full names. |
| const BTC_TEXT = "Bitcoin" | ||
| const USD_TEXT = "Dollar" |
There was a problem hiding this comment.
These constants are now user-facing English words but the component doesn’t use i18n, which will prevent localization and diverges from the CurrencyPill pattern (it uses LL.common.bitcoin() / LL.common.dollar()). Consider sourcing these labels from i18n instead of hard-coding them here.
| "receiveBitcoinDescription": "Receive Bitcoin using your phone number", | ||
| "dailyLimitDescription": "Send up to $1,000 USD per day", | ||
| "dailyLimitDescription": "Send up to $1,000 per day", | ||
| "onchainDescription": "Receive on-chain payments" |
There was a problem hiding this comment.
This string used to explicitly state the unit as USD (and other locales like es.json still do). Removing “USD” changes the meaning/clarity of the limit; consider keeping “USD” (or updating all locales consistently) so users know the limit is denominated in dollars.
| title: "New features unlocked for your account:", | ||
| receiveBitcoinDescription: "Receive Bitcoin using your phone number", | ||
| dailyLimitDescription: "Send up to $1,000 USD per day", | ||
| dailyLimitDescription: "Send up to $1,000 per day", | ||
| onchainDescription: "Receive on-chain payments", |
There was a problem hiding this comment.
This description no longer specifies the currency (previously “$1,000 USD per day”, and other locales still include USD). Consider keeping “USD” here (or aligning all locales) so the onboarding limit remains unambiguous.
| </Text> | ||
| <Text selectable> | ||
| USD per 1 sat: {usdPerSat ? `$${usdPerSat}` : "No price data"} | ||
| per 1 sat: {usdPerSat ? `$${usdPerSat}` : "No price data"} |
There was a problem hiding this comment.
This label became ambiguous after dropping the currency name. Since the value is explicitly usdPerSat and formatted with $, the text should still indicate USD (or “US Dollar”) to avoid misreading it as another display currency.
| per 1 sat: {usdPerSat ? `$${usdPerSat}` : "No price data"} | |
| USD per 1 sat: {usdPerSat ? `$${usdPerSat}` : "No price data"} |
| <View> | ||
| <Text>BTC</Text> | ||
| <Text>Bitcoin</Text> | ||
| </View> | ||
| </TouchableWithoutFeedback> | ||
| <TouchableWithoutFeedback | ||
| onPress={() => setReceiveCurrency(WalletCurrency.Usd)} | ||
| > | ||
| <View> | ||
| <Text>USD</Text> | ||
| <Text>Dollar</Text> | ||
| </View> |
There was a problem hiding this comment.
These currency tab labels are now English words and the screen already uses i18n (LL). To keep localization consistent, use existing i18n currency strings (e.g. LL.common.bitcoin() / LL.common.dollar()) instead of hard-coded text.
|
@blink-claw-bot Please resolve the conflicts in this PR and review/fix/dismiss the issues from copilot. |
|
Let's try that again! |
Revert two renames that touched amount/rate contexts: restore "USD per 1 sat" in the developer screen (a rate) and "$1,000 USD per day" in the daily limit description (an amount). Type/account labels keep the Bitcoin/Dollar rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
I checked this PR. It is from the external fork Merge simulation against current
Copilot items to address while resolving:
I can take the branch and push the conflict/Copilot fixes if |
…-and-usd-names # Conflicts: # app/i18n/en/index.ts # app/i18n/i18n-types.ts # app/i18n/raw-i18n/source/en.json
Changes shouldnt apply to amounts ex "0.00000001 BTC"
or currencies 1 BTC = {btcToUsdRate}
Rest of the renaming seems correct to me