Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import { makeStyles, Text, TextProps, useTheme } from "@rn-vui/themed"

import { WalletCurrency } from "@app/graphql/generated"

const BTC_TEXT = "BTC"
const USD_TEXT = "USD"
const BTC_TEXT = "Bitcoin"
const USD_TEXT = "Dollar"
Comment on lines +7 to +8

Copilot AI Feb 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These constants are now user-facing English words but the component doesn’t use i18n, which will prevent localization and diverges from the CurrencyPill pattern (it uses LL.common.bitcoin() / LL.common.dollar()). Consider sourcing these labels from i18n instead of hard-coding them here.

Copilot uses AI. Check for mistakes.
const DEFAULT_TEXT_SIZE = "p3"

type ContainerSize = "small" | "medium" | "large"
Expand Down
4 changes: 2 additions & 2 deletions app/components/wallet-summary/wallet-summary.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const Wrapper = ({ children, text }) => {

export const Default = () => (
<View>
<Wrapper text="BTC">
<Wrapper text="Bitcoin">
<WalletSummary
amountType="SEND"
settlementAmount={{
Expand All @@ -51,7 +51,7 @@ export const Default = () => (
txDisplayCurrency="USD"
/>
</Wrapper>
<Wrapper text="USD">
<Wrapper text="Dollar">
<WalletSummary
amountType="SEND"
settlementAmount={{
Expand Down
10 changes: 5 additions & 5 deletions app/i18n/en/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ const en: BaseTranslation = {
"The look and design of paper bills is updated every 10 years or so.",
],
feedback: [
"Correct. This is true even for USD, which has lost 97% of its value during the last 100 years.",
"Correct. This is true even for the US Dollar, which has lost 97% of its value during the last 100 years.",
"Incorrect. Please try again.",
"Not quite. Although the design of papers bills may change, this has nothing to do with their value.",
],
Expand Down Expand Up @@ -2293,7 +2293,7 @@ const en: BaseTranslation = {
'When you enter a {bankName: string} username, we will add "@{lnDomain: string}" to it (e.g maria@{lnDomain: string}) to make it an address. Your username is now a {bankName: string} address too.\n\nGo to your {bankName: string} address page from your Settings to learn how to use it or to share it to receive payments.',
enterValidDestination: "Enter a valid destination",
destinationOptions:
"You can send to a {bankName: string} address, LN address, LN invoice, or BTC address.",
"You can send to a {bankName: string} address, LN address, LN invoice, or Bitcoin address.",
expiredInvoice: "This invoice has expired. Please generate a new invoice.",
wrongNetwork:
"This invoice is for a different network. Please generate a new invoice.",
Expand All @@ -2302,14 +2302,14 @@ const en: BaseTranslation = {
usernameDoesNotExist:
"{lnAddress: string} doesn't seem to be a {bankName: string} address that exists.",
usernameDoesNotExistAdvice:
"Either make sure the spelling is right or ask the recipient for an LN invoice or BTC address instead.",
"Either make sure the spelling is right or ask the recipient for an LN invoice or Bitcoin address instead.",
selfPaymentError: "{lnAddress: string} is your {bankName: string} address.",
selfPaymentAdvice:
"If you want to send money to another account that you own, you can use an invoice, LN or BTC address instead.",
"If you want to send money to another account that you own, you can use an invoice, LN or Bitcoin address instead.",
lnAddressError:
"We can't reach this Lightning address. If you are sure it exists, you can try again later.",
lnAddressAdvice:
"Either make sure the spelling is right or ask the recipient for an invoice or BTC address instead.",
"Either make sure the spelling is right or ask the recipient for an invoice or Bitcoin address instead.",
unknownLightning: "We can't parse this Lightning address. Please try again.",
unknownOnchain: "We can't parse this Bitcoin address. Please try again.",
newBankAddressUsername:
Expand Down
20 changes: 10 additions & 10 deletions app/i18n/i18n-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1020,7 +1020,7 @@ type RootTranslation = {
}
feedback: {
/**
* C​o​r​r​e​c​t​.​ ​T​h​i​s​ ​i​s​ ​t​r​u​e​ ​e​v​e​n​ ​f​o​r​ ​U​S​D​,​ ​w​h​i​c​h​ ​h​a​s​ ​l​o​s​t​ ​9​7​%​ ​o​f​ ​i​t​s​ ​v​a​l​u​e​ ​d​u​r​i​n​g​ ​t​h​e​ ​l​a​s​t​ ​1​0​0​ ​y​e​a​r​s​.
* C​o​r​r​e​c​t​.​ ​T​h​i​s​ ​i​s​ ​t​r​u​e​ ​e​v​e​n​ ​f​o​r​ ​t​h​e​ ​U​S​ ​D​o​l​l​a​r​,​ ​w​h​i​c​h​ ​h​a​s​ ​l​o​s​t​ ​9​7​%​ ​o​f​ ​i​t​s​ ​v​a​l​u​e​ ​d​u​r​i​n​g​ ​t​h​e​ ​l​a​s​t​ ​1​0​0​ ​y​e​a​r​s​.
*/
'0': string
/**
Expand Down Expand Up @@ -7156,7 +7156,7 @@ type RootTranslation = {
*/
enterValidDestination: string
/**
* Y​o​u​ ​c​a​n​ ​s​e​n​d​ ​t​o​ ​a​ ​{​b​a​n​k​N​a​m​e​}​ ​a​d​d​r​e​s​s​,​ ​L​N​ ​a​d​d​r​e​s​s​,​ ​L​N​ ​i​n​v​o​i​c​e​,​ ​o​r​ ​B​T​C​ ​a​d​d​r​e​s​s​.
* Y​o​u​ ​c​a​n​ ​s​e​n​d​ ​t​o​ ​a​ ​{​b​a​n​k​N​a​m​e​}​ ​a​d​d​r​e​s​s​,​ ​L​N​ ​a​d​d​r​e​s​s​,​ ​L​N​ ​i​n​v​o​i​c​e​,​ ​o​r​ ​B​i​t​c​o​i​n​ ​a​d​d​r​e​s​s​.
* @param {string} bankName
*/
destinationOptions: RequiredParams<'bankName'>
Expand All @@ -7179,7 +7179,7 @@ type RootTranslation = {
*/
usernameDoesNotExist: RequiredParams<'bankName' | 'lnAddress'>
/**
* E​i​t​h​e​r​ ​m​a​k​e​ ​s​u​r​e​ ​t​h​e​ ​s​p​e​l​l​i​n​g​ ​i​s​ ​r​i​g​h​t​ ​o​r​ ​a​s​k​ ​t​h​e​ ​r​e​c​i​p​i​e​n​t​ ​f​o​r​ ​a​n​ ​L​N​ ​i​n​v​o​i​c​e​ ​o​r​ ​B​T​C​ ​a​d​d​r​e​s​s​ ​i​n​s​t​e​a​d​.
* E​i​t​h​e​r​ ​m​a​k​e​ ​s​u​r​e​ ​t​h​e​ ​s​p​e​l​l​i​n​g​ ​i​s​ ​r​i​g​h​t​ ​o​r​ ​a​s​k​ ​t​h​e​ ​r​e​c​i​p​i​e​n​t​ ​f​o​r​ ​a​n​ ​L​N​ ​i​n​v​o​i​c​e​ ​o​r​ ​B​i​t​c​o​i​n​ ​a​d​d​r​e​s​s​ ​i​n​s​t​e​a​d​.
*/
usernameDoesNotExistAdvice: string
/**
Expand All @@ -7189,15 +7189,15 @@ type RootTranslation = {
*/
selfPaymentError: RequiredParams<'bankName' | 'lnAddress'>
/**
* I​f​ ​y​o​u​ ​w​a​n​t​ ​t​o​ ​s​e​n​d​ ​m​o​n​e​y​ ​t​o​ ​a​n​o​t​h​e​r​ ​a​c​c​o​u​n​t​ ​t​h​a​t​ ​y​o​u​ ​o​w​n​,​ ​y​o​u​ ​c​a​n​ ​u​s​e​ ​a​n​ ​i​n​v​o​i​c​e​,​ ​L​N​ ​o​r​ ​B​T​C​ ​a​d​d​r​e​s​s​ ​i​n​s​t​e​a​d​.
* I​f​ ​y​o​u​ ​w​a​n​t​ ​t​o​ ​s​e​n​d​ ​m​o​n​e​y​ ​t​o​ ​a​n​o​t​h​e​r​ ​a​c​c​o​u​n​t​ ​t​h​a​t​ ​y​o​u​ ​o​w​n​,​ ​y​o​u​ ​c​a​n​ ​u​s​e​ ​a​n​ ​i​n​v​o​i​c​e​,​ ​L​N​ ​o​r​ ​B​i​t​c​o​i​n​ ​a​d​d​r​e​s​s​ ​i​n​s​t​e​a​d​.
*/
selfPaymentAdvice: string
/**
* W​e​ ​c​a​n​'​t​ ​r​e​a​c​h​ ​t​h​i​s​ ​L​i​g​h​t​n​i​n​g​ ​a​d​d​r​e​s​s​.​ ​I​f​ ​y​o​u​ ​a​r​e​ ​s​u​r​e​ ​i​t​ ​e​x​i​s​t​s​,​ ​y​o​u​ ​c​a​n​ ​t​r​y​ ​a​g​a​i​n​ ​l​a​t​e​r​.
*/
lnAddressError: string
/**
* E​i​t​h​e​r​ ​m​a​k​e​ ​s​u​r​e​ ​t​h​e​ ​s​p​e​l​l​i​n​g​ ​i​s​ ​r​i​g​h​t​ ​o​r​ ​a​s​k​ ​t​h​e​ ​r​e​c​i​p​i​e​n​t​ ​f​o​r​ ​a​n​ ​i​n​v​o​i​c​e​ ​o​r​ ​B​T​C​ ​a​d​d​r​e​s​s​ ​i​n​s​t​e​a​d​.
* E​i​t​h​e​r​ ​m​a​k​e​ ​s​u​r​e​ ​t​h​e​ ​s​p​e​l​l​i​n​g​ ​i​s​ ​r​i​g​h​t​ ​o​r​ ​a​s​k​ ​t​h​e​ ​r​e​c​i​p​i​e​n​t​ ​f​o​r​ ​a​n​ ​i​n​v​o​i​c​e​ ​o​r​ ​B​i​t​c​o​i​n​ ​a​d​d​r​e​s​s​ ​i​n​s​t​e​a​d​.
*/
lnAddressAdvice: string
/**
Expand Down Expand Up @@ -13329,7 +13329,7 @@ export type TranslationFunctions = {
}
feedback: {
/**
* Correct. This is true even for USD, which has lost 97% of its value during the last 100 years.
* Correct. This is true even for the US Dollar, which has lost 97% of its value during the last 100 years.
*/
'0': () => LocalizedString
/**
Expand Down Expand Up @@ -19435,7 +19435,7 @@ export type TranslationFunctions = {
*/
enterValidDestination: () => LocalizedString
/**
* You can send to a {bankName} address, LN address, LN invoice, or BTC address.
* You can send to a {bankName} address, LN address, LN invoice, or Bitcoin address.
*/
destinationOptions: (arg: { bankName: string }) => LocalizedString
/**
Expand All @@ -19455,23 +19455,23 @@ export type TranslationFunctions = {
*/
usernameDoesNotExist: (arg: { bankName: string, lnAddress: string }) => LocalizedString
/**
* Either make sure the spelling is right or ask the recipient for an LN invoice or BTC address instead.
* Either make sure the spelling is right or ask the recipient for an LN invoice or Bitcoin address instead.
*/
usernameDoesNotExistAdvice: () => LocalizedString
/**
* {lnAddress} is your {bankName} address.
*/
selfPaymentError: (arg: { bankName: string, lnAddress: string }) => LocalizedString
/**
* If you want to send money to another account that you own, you can use an invoice, LN or BTC address instead.
* If you want to send money to another account that you own, you can use an invoice, LN or Bitcoin address instead.
*/
selfPaymentAdvice: () => LocalizedString
/**
* We can't reach this Lightning address. If you are sure it exists, you can try again later.
*/
lnAddressError: () => LocalizedString
/**
* Either make sure the spelling is right or ask the recipient for an invoice or BTC address instead.
* Either make sure the spelling is right or ask the recipient for an invoice or Bitcoin address instead.
*/
lnAddressAdvice: () => LocalizedString
/**
Expand Down
10 changes: 5 additions & 5 deletions app/i18n/raw-i18n/source/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@
"The look and design of paper bills is updated every 10 years or so."
],
"feedback": [
"Correct. This is true even for USD, which has lost 97% of its value during the last 100 years.",
"Correct. This is true even for the US Dollar, which has lost 97% of its value during the last 100 years.",
"Incorrect. Please try again.",
"Not quite. Although the design of papers bills may change, this has nothing to do with their value."
],
Expand Down Expand Up @@ -2234,16 +2234,16 @@
"usernameNowAddress": "{bankName: string} usernames are now {bankName: string} addresses.",
"usernameNowAddressInfo": "When you enter a {bankName: string} username, we will add \"@{lnDomain: string}\" to it (e.g maria@{lnDomain: string}) to make it an address. Your username is now a {bankName: string} address too.\n\nGo to your {bankName: string} address page from your Settings to learn how to use it or to share it to receive payments.",
"enterValidDestination": "Enter a valid destination",
"destinationOptions": "You can send to a {bankName: string} address, LN address, LN invoice, or BTC address.",
"destinationOptions": "You can send to a {bankName: string} address, LN address, LN invoice, or Bitcoin address.",
"expiredInvoice": "This invoice has expired. Please generate a new invoice.",
"wrongNetwork": "This invoice is for a different network. Please generate a new invoice.",
"invalidAmount": "This contains an invalid amount. Please regenerate with a valid amount.",
"usernameDoesNotExist": "{lnAddress: string} doesn't seem to be a {bankName: string} address that exists.",
"usernameDoesNotExistAdvice": "Either make sure the spelling is right or ask the recipient for an LN invoice or BTC address instead.",
"usernameDoesNotExistAdvice": "Either make sure the spelling is right or ask the recipient for an LN invoice or Bitcoin address instead.",
"selfPaymentError": "{lnAddress: string} is your {bankName: string} address.",
"selfPaymentAdvice": "If you want to send money to another account that you own, you can use an invoice, LN or BTC address instead.",
"selfPaymentAdvice": "If you want to send money to another account that you own, you can use an invoice, LN or Bitcoin address instead.",
"lnAddressError": "We can't reach this Lightning address. If you are sure it exists, you can try again later.",
"lnAddressAdvice": "Either make sure the spelling is right or ask the recipient for an invoice or BTC address instead.",
"lnAddressAdvice": "Either make sure the spelling is right or ask the recipient for an invoice or Bitcoin address instead.",
"unknownLightning": "We can't parse this Lightning address. Please try again.",
"unknownOnchain": "We can't parse this Bitcoin address. Please try again.",
"newBankAddressUsername": "{lnAddress: string} exists as a {bankName: string} address, but you've never sent money to it.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,14 +126,14 @@ const RedeemBitcoinDetailScreen: React.FC<Prop> = ({ route }) => {
onPress={() => setReceiveCurrency(WalletCurrency.Btc)}
>
<View>
<Text>BTC</Text>
<Text>Bitcoin</Text>
</View>
</TouchableWithoutFeedback>
<TouchableWithoutFeedback
onPress={() => setReceiveCurrency(WalletCurrency.Usd)}
>
<View>
<Text>USD</Text>
<Text>Dollar</Text>
</View>
Comment on lines 128 to 137

Copilot AI Feb 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These currency tab labels are now English words and the screen already uses i18n (LL). To keep localization consistent, use existing i18n currency strings (e.g. LL.common.bitcoin() / LL.common.dollar()) instead of hard-coded text.

Copilot uses AI. Check for mistakes.
</TouchableWithoutFeedback>
</View>
Expand Down
Loading