Conversation
Signed-off-by: Chris Gianelloni <wolf31o2@blinklabs.io>
📝 WalkthroughWalkthroughAdds a typed union for governance actions and numerous concrete action payload structs (Info, NoConfidence, HardForkInitiation, TreasuryWithdrawal, UpdateCommittee, NewConstitution, ParameterChange, and related nested types such as ProtocolParameterUpdateData, ExUnitsData, ExecutionCosts, and voting thresholds). Extends ProposalProcedureData with an ActionData field. Implements extractors to convert internal GovAction representations into the new public structs (including helpers for protocol parameter conversion and rational-to-float conversion). Adds unit tests covering GovAction extraction, GovActionId handling, and rational conversion. Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Closes #484
Summary by cubic
Adds full governance action extraction and serialization to ProposalProcedure events. Clients now receive detailed Conway governance data, including action specifics and parameter updates.
Written for commit 131c310. Summary will update on new commits.
Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.