Fix PHP fatal error in get_icons() #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

anktd wants to merge 2 commits into blockonomics:master from anktd:fix-get_icons

Collaborator

anktd commented Dec 30, 2025 •

edited

Loading

This PR fixes #403 by adding 2 things:

Initialize $icons_src = [] -> prevents undefined variable if loop never runs
Early return if error -> checks for error key or empty array before iterating

Tested both scenarios:

Without API key - no more warnings/fatal errors
With API key - icons should still work normally

Added unit test for get_icons error handling

Test error response when API key not configured
Test empty response handling
Test valid cryptos (BTC + USDT)
Test single crypto scenarios (BTC only, USDT only)

anktd added 2 commits

December 30, 2025 12:03


          Fix PHP fatal error in get_icons() when API key not configured

db12fe4


          add unit test for get_icons error handling

3fb87b9

anktd mentioned this pull request

Fix blockonomics_data has already been declared error #406

Open

anktd added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug