Skip to content

Fix PHP fatal error in get_icons() #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anktd wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix PHP fatal error in get_icons() #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db12fe4
Fix PHP fatal error in get_icons() when API key not configured
anktd Dec 30, 2025
3fb87b9
add unit test for get_icons error handling
anktd Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions php/class-wc-blockonomics-blocks-support.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ private function get_icons() {
include_once 'Blockonomics.php';
$blockonomics = new Blockonomics;
$active_cryptos = $blockonomics->getActiveCurrencies();
$icons_src = [];
if (empty($active_cryptos) || isset($active_cryptos['error']) ){
return $icons_src;
}

foreach ($active_cryptos as $code => $crypto) {
$icons_src[$crypto['code']] = [
Expand Down
94 changes: 94 additions & 0 deletions tests/BlockonomicsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,100 @@ public function testGetSupportedCurrencies() {
$this->assertEquals($expectedCurrencies, $actualCurrencies, "The getSupportedCurrencies method did not return the expected array of cryptocurrencies.");
}

public function testIconsGenerationWithErrorResponse() {
$active_cryptos = ['error' => 'API Key is not set. Please enter your API Key.'];
$icons_src = [];

if (empty($active_cryptos) || isset($active_cryptos['error'])) {
// Should return empty
$this->assertEmpty($icons_src, "Icons should be empty when error response received");
return;
}

$this->fail('Should have returned early due to error');
}

public function testIconsGenerationWithValidCryptos() {
$active_cryptos = [
'btc' => ['code' => 'btc', 'name' => 'Bitcoin', 'uri' => 'bitcoin', 'decimals' => 8],
'usdt' => ['code' => 'usdt', 'name' => 'USDT', 'decimals' => 6]
];
$icons_src = [];

if (empty($active_cryptos) || isset($active_cryptos['error'])) {
$this->fail('Should not return early for valid cryptos');
}

foreach ($active_cryptos as $code => $crypto) {
$icons_src[$crypto['code']] = [
'src' => 'test/'.$crypto['code'].'.png',
'alt' => $crypto['name'],
];
}

$this->assertCount(2, $icons_src, "Should have icons for 2 cryptocurrencies");
$this->assertArrayHasKey('btc', $icons_src, "Should have BTC icon");
$this->assertArrayHasKey('usdt', $icons_src, "Should have USDT icon");
$this->assertEquals('Bitcoin', $icons_src['btc']['alt'], "BTC alt text should be 'Bitcoin'");
$this->assertEquals('USDT', $icons_src['usdt']['alt'], "USDT alt text should be 'USDT'");
}

public function testIconsGenerationWithEmptyResponse() {
$active_cryptos = [];
$icons_src = [];

if (empty($active_cryptos) || isset($active_cryptos['error'])) {
$this->assertEmpty($icons_src, "Icons should be empty when no active cryptos");
return;
}

$this->fail('Should have returned early due to empty array');
}

public function testIconsGenerationWithSingleCryptoBTC() {
$active_cryptos = [
'btc' => ['code' => 'btc', 'name' => 'Bitcoin', 'uri' => 'bitcoin', 'decimals' => 8]
];
$icons_src = [];

if (empty($active_cryptos) || isset($active_cryptos['error'])) {
$this->fail('Should not return early for valid crypto');
}

foreach ($active_cryptos as $code => $crypto) {
$icons_src[$crypto['code']] = [
'src' => 'test/'.$crypto['code'].'.png',
'alt' => $crypto['name'],
];
}

$this->assertCount(1, $icons_src, "Should have icon for 1 cryptocurrency");
$this->assertArrayHasKey('btc', $icons_src, "Should have BTC icon");
$this->assertEquals('Bitcoin', $icons_src['btc']['alt']);
}

public function testIconsGenerationWithSingleCryptoUSDT() {
$active_cryptos = [
'usdt' => ['code' => 'usdt', 'name' => 'USDT', 'decimals' => 6]
];
$icons_src = [];

if (empty($active_cryptos) || isset($active_cryptos['error'])) {
$this->fail('Should not return early for valid crypto');
}

foreach ($active_cryptos as $code => $crypto) {
$icons_src[$crypto['code']] = [
'src' => 'test/'.$crypto['code'].'.png',
'alt' => $crypto['name'],
];
}

$this->assertCount(1, $icons_src, "Should have icon for 1 cryptocurrency");
$this->assertArrayHasKey('usdt', $icons_src, "Should have USDT icon");
$this->assertEquals('USDT', $icons_src['usdt']['alt']);
}


protected function tearDown(): void {
wp::tearDown();
Expand Down