Skip to content

feat: Waitlist Lottery - Adjust Doorway Listing Type Filter#5559

Merged
millord merged 6 commits into
mainfrom
5506/waitlist-lottery-adjust-doorway-listing-type-filter-core
Nov 13, 2025
Merged

feat: Waitlist Lottery - Adjust Doorway Listing Type Filter#5559
millord merged 6 commits into
mainfrom
5506/waitlist-lottery-adjust-doorway-listing-type-filter-core

Conversation

@millord

@millord millord commented Nov 10, 2025

Copy link
Copy Markdown
Collaborator

This PR addresses #5506

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Please include a summary of the change and which issue(s) is addressed.

How Can This Be Tested/Reviewed?

  1. Go to the partners site and create two listing.
  • open waitlist lottery
  • available units
  1. Go to the public site, select the filter and filter by open waitlist
  • should see the open waitlist lottery listing you created
  1. select the filter and filter by available units
  • should see the available units listing you created

Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@millord millord changed the title updating test after changes for test builder feat: [] updating test after changes for test builder Nov 10, 2025
@millord millord changed the title feat: [] updating test after changes for test builder feat: Waitlist Lottery - Adjust Doorway Listing Type Filter Nov 10, 2025
@netlify

netlify Bot commented Nov 10, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit 9c87542
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/6916091e2339e60008ebc845

@netlify

netlify Bot commented Nov 10, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-flagly canceled.

Name Link
🔨 Latest commit 9c87542
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/6916091e5279ae0008eca5a4

@netlify

netlify Bot commented Nov 10, 2025

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 9c87542
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6916091ebbcedc000860d75c
😎 Deploy Preview https://deploy-preview-5559--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread api/src/services/listing.service.ts
@mcgarrye mcgarrye added needs changes The author must make changes and then re-request review before merging 1 review needed Requires 1 more review before ready to merge labels Nov 12, 2025
@netlify

netlify Bot commented Nov 12, 2025

Copy link
Copy Markdown

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 2d00bb6
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/6914dd435588f00008bbb481
😎 Deploy Preview https://deploy-preview-5559--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread api/src/services/listing.service.ts Outdated
Comment thread api/src/services/listing.service.ts Outdated

@mcgarrye mcgarrye left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcgarrye mcgarrye added ready to merge Should be applied when a PR has been reviewed and approved and removed needs changes The author must make changes and then re-request review before merging 1 review needed Requires 1 more review before ready to merge labels Nov 13, 2025
@millord millord merged commit 71dbe84 into main Nov 13, 2025
34 checks passed
@millord millord deleted the 5506/waitlist-lottery-adjust-doorway-listing-type-filter-core branch November 13, 2025 20:35
mcgarrye pushed a commit to metrotranscom/doorway that referenced this pull request Nov 19, 2025
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Nov 24, 2025
ludtkemorgan pushed a commit to metrotranscom/doorway that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants