feat: add other-portals banner to Select Jurisdiction modal#6312
feat: add other-portals banner to Select Jurisdiction modal#6312Copilot wants to merge 10 commits into
Conversation
✅ Deploy Preview for partners-bloom-msq2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
… gate Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/0b280efa-850c-4c1e-850e-e0f115012c7f Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/0b280efa-850c-4c1e-850e-e0f115012c7f Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
emilyjablonski
left a comment
There was a problem hiding this comment.
Need to add the strings
….json Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/d78ab239-5d3d-4ae3-8c64-e5f2f8e60f09 Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
emilyjablonski
left a comment
There was a problem hiding this comment.
Red border needs to be thicker. List of portals needs to actually be a list. It should be full width as well.
Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/1e2ca627-eb44-4d48-bde9-e6eb05780e62 Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
Done in commit
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
emilyjablonski
left a comment
There was a problem hiding this comment.
- There's not enough spacing above the banner and too much below. Can it be in the same cell the dropdown is in?
- We need to use the SCSS module files and ui-seeds variables instead of Tailwind
Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/5153c8f2-7156-4f00-a3fc-3dae5d1696de Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/5153c8f2-7156-4f00-a3fc-3dae5d1696de Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/5153c8f2-7156-4f00-a3fc-3dae5d1696de Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
Done in commit
|
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
We should chat as a team, but I'm not a fan of the existing red border UI - I think text linking to other portals would suffice and be less jarring. It's also not a pattern we have anywhere else - we could use an alert if we think we need to call particular attention. |
#6229
Moves the "other portals" banner concept from the listing address page into the Select Jurisdiction modal, where it's contextually more useful — the user has already chosen a jurisdiction by the time they reach the address section.
Description
The banner is gated via
tIfExists: generic translation keyslistings.otherPortals.*are defined in core's partner locale file with placeholder content, and forks override them with real portal names and URLs.sites/partners/src/pages/index.tsxtIfExistsfrom@bloom-housing/shared-helpersandLinkfrom@bloom-housing/ui-seedstIfExistsresults as component-level variables (title, portal1 name/url, portal2 name/url) to avoid redundant callsGrid.Cellas the Jurisdiction dropdown, directly above it; suppressed whendefaultJurisdictionis set (single-jurisdiction users see "Select Listing Type" instead)index.module.scss) using ui-seeds variables: thick alert-colored border, padding, and bulleted list for portal linkssites/partners/src/pages/index.module.scss(new file).other-portals-bannerstyles using ui-seeds variables:border: var(--seeds-border-2) solid var(--seeds-color-alert)padding: var(--seeds-s4)ul:list-style-type: disc; margin-block-start: var(--seeds-s2); padding-left: var(--seeds-s5)sites/partners/page_content/locales/general.jsonlistings.otherPortals.*keys so the banner renders in core with placeholder text; forks override with real portal names and URLs:listings.otherPortals.title:"To add listings in other jurisdictions, use one of these portals:"listings.otherPortals.portal1.name/.portal1.urllistings.otherPortals.portal2.name/.portal2.urlsites/partners/__tests__/pages/listings/index.test.tsxtIfExistsviajest.mock+require()pattern; reset inafterEachdescribe("other portals banner"):tIfExistsreturnsnullhrefs when keys are present (fork scenario)How Can This Be Tested/Reviewed?
listings.otherPortals.title,listings.otherPortals.portal1.name,listings.otherPortals.portal1.url,listings.otherPortals.portal2.name,listings.otherPortals.portal2.urlwith real portal names and URLs — the banner should reflect the fork-specific contentAuthor Checklist:
yarn generate:clientand/or created a migration when required