Skip to content

feat: add other-portals banner to Select Jurisdiction modal#6312

Merged
emilyjablonski merged 15 commits into
mainfrom
copilot/update-partner-portal-banner
Jun 17, 2026
Merged

feat: add other-portals banner to Select Jurisdiction modal#6312
emilyjablonski merged 15 commits into
mainfrom
copilot/update-partner-portal-banner

Conversation

Copilot AI commented May 14, 2026

Copy link
Copy Markdown
Contributor

#6229

Add an "other portals" banner concept into the Select Jurisdiction modal.

Description

The banner only appears if the title string listings.otherPortals.title exists in the partners overrides files. You can add any number of portal titles and URLs and it will iterate and display them all in a list. If a fork doesn't want this to appear, you just need to remove that title key.

How Can This Be Tested/Reviewed?

As an admin w access to multiple jurisdictions, open the Add listing modal. The banner should appear below the Jurisdiction dropdown with generic placeholder text.

Screenshot 2026-06-11 at 3 40 40 PM

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

@netlify

netlify Bot commented May 14, 2026

Copy link
Copy Markdown

Deploy Preview for partners-bloom-msq2 ready!

Name Link
🔨 Latest commit 63618d9
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-msq2/deploys/6a0755ab9dd38d0008faecc1
😎 Deploy Preview https://deploy-preview-6312--partners-bloom-msq2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 14, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit 63618d9
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/6a0755ab9dd38d0008faecbf

… gate

Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/0b280efa-850c-4c1e-850e-e0f115012c7f

Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
@netlify

netlify Bot commented May 14, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 63618d9
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/6a0755abe6dc4100080303d1
😎 Deploy Preview https://deploy-preview-6312--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 14, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 63618d9
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/6a0755abbc9de5000817142f
😎 Deploy Preview https://deploy-preview-6312--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI changed the title [WIP] Update partner portal banner location to modal Add optional other-portals banner to Select Jurisdiction modal May 14, 2026
Copilot AI requested a review from emilyjablonski May 14, 2026 20:42
Comment thread sites/partners/src/pages/index.tsx

@emilyjablonski emilyjablonski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment!

@emilyjablonski emilyjablonski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add the strings

….json

Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/d78ab239-5d3d-4ae3-8c64-e5f2f8e60f09

Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
Copilot AI changed the title Add optional other-portals banner to Select Jurisdiction modal Add other-portals banner to Select Jurisdiction modal May 14, 2026
Copilot AI requested a review from emilyjablonski May 14, 2026 21:00

@emilyjablonski emilyjablonski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Red border needs to be thicker. List of portals needs to actually be a list. It should be full width as well.

Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/1e2ca627-eb44-4d48-bde9-e6eb05780e62

Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>

Copilot AI commented May 14, 2026

Copy link
Copy Markdown
Contributor Author

Red border needs to be thicker. List of portals needs to actually be a list. It should be full width as well.

Done in commit 95980df:

  • Border thickened: borderborder-2
  • List gets list-disc pl-5 for bullet styling
  • Banner moved outside the <Grid> to span the full Dialog content width

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • download.cypress.io
    • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node index.js --exec install (dns block)
  • downloads.sentry-cdn.com
    • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node ./scripts/install.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@emilyjablonski emilyjablonski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. There's not enough spacing above the banner and too much below. Can it be in the same cell the dropdown is in?
  2. We need to use the SCSS module files and ui-seeds variables instead of Tailwind

Copilot AI and others added 3 commits May 14, 2026 21:19
Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/5153c8f2-7156-4f00-a3fc-3dae5d1696de

Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/5153c8f2-7156-4f00-a3fc-3dae5d1696de

Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>

Copilot AI commented May 14, 2026

Copy link
Copy Markdown
Contributor Author
  1. There's not enough spacing above the banner and too much below. Can it be in the same cell the dropdown is in?
  2. We need to use the SCSS module files and ui-seeds variables instead of Tailwind

Done in commit 5a71b4d:

  1. Banner moved back into the same Grid.Cell as the Jurisdiction dropdown — spacing is now handled naturally by the cell layout and the existing seeds-m-bs-4 on the Select wrapper.
  2. Replaced all Tailwind classes with a new index.module.scss using ui-seeds variables:
    • border: var(--seeds-border-2) solid var(--seeds-color-alert)
    • padding: var(--seeds-s4)
    • List: list-style-type: disc; padding-left: var(--seeds-s5) with margin-block-start: var(--seeds-s2) for spacing between title and list

@netlify

netlify Bot commented May 14, 2026

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 63618d9
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6a0755ab9dd38d0008faecb8
😎 Deploy Preview https://deploy-preview-6312--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski changed the title Add other-portals banner to Select Jurisdiction modal feat: add other-portals banner to Select Jurisdiction modal May 14, 2026
@emilyjablonski

emilyjablonski commented May 15, 2026

Copy link
Copy Markdown
Collaborator

We should chat as a team, but I'm not a fan of the existing red border UI - I think text linking to other portals would suffice and be less jarring. It's also not a pattern we have anywhere else - we could use an alert if we think we need to call particular attention.

@netlify

netlify Bot commented Jun 11, 2026

Copy link
Copy Markdown

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit bb7811a
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/6a2b2dbfcad59600076863f9
😎 Deploy Preview https://deploy-preview-6312--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 11, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit bb7811a
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/6a2b2dbf700ef500082744ff

@netlify

netlify Bot commented Jun 11, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit bb7811a
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/6a2b2dbfb2d6420008e13e55
😎 Deploy Preview https://deploy-preview-6312--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Jun 11, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit bb7811a
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/6a2b2dbff309130008f7dd98
😎 Deploy Preview https://deploy-preview-6312--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@emilyjablonski emilyjablonski marked this pull request as ready for review June 12, 2026 16:42
@emilyjablonski emilyjablonski added the 1 review needed Requires 1 more review before ready to merge label Jun 12, 2026

@ludtkemorgan ludtkemorgan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread sites/partners/src/pages/index.tsx
Comment thread sites/partners/page_content/overrides/general.json
@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jun 16, 2026
@emilyjablonski emilyjablonski merged commit 9360326 into main Jun 17, 2026
28 checks passed
@emilyjablonski emilyjablonski deleted the copilot/update-partner-portal-banner branch June 17, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doorway feature: Partner portal other portal banner

3 participants