feat: add other-portals banner to Select Jurisdiction modal#6312
Conversation
✅ Deploy Preview for partners-bloom-msq2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
… gate Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/0b280efa-850c-4c1e-850e-e0f115012c7f Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/0b280efa-850c-4c1e-850e-e0f115012c7f Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
emilyjablonski
left a comment
There was a problem hiding this comment.
Need to add the strings
….json Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/d78ab239-5d3d-4ae3-8c64-e5f2f8e60f09 Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
emilyjablonski
left a comment
There was a problem hiding this comment.
Red border needs to be thicker. List of portals needs to actually be a list. It should be full width as well.
Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/1e2ca627-eb44-4d48-bde9-e6eb05780e62 Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
Done in commit
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
emilyjablonski
left a comment
There was a problem hiding this comment.
- There's not enough spacing above the banner and too much below. Can it be in the same cell the dropdown is in?
- We need to use the SCSS module files and ui-seeds variables instead of Tailwind
Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/5153c8f2-7156-4f00-a3fc-3dae5d1696de Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/5153c8f2-7156-4f00-a3fc-3dae5d1696de Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bloom-housing/bloom/sessions/5153c8f2-7156-4f00-a3fc-3dae5d1696de Co-authored-by: emilyjablonski <65367387+emilyjablonski@users.noreply.github.com>
Done in commit
|
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
We should chat as a team, but I'm not a fan of the existing red border UI - I think text linking to other portals would suffice and be less jarring. It's also not a pattern we have anywhere else - we could use an alert if we think we need to call particular attention. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
#6229
Add an "other portals" banner concept into the Select Jurisdiction modal.
Description
The banner only appears if the title string
listings.otherPortals.titleexists in the partners overrides files. You can add any number of portal titles and URLs and it will iterate and display them all in a list. If a fork doesn't want this to appear, you just need to remove that title key.How Can This Be Tested/Reviewed?
As an admin w access to multiple jurisdictions, open the Add listing modal. The banner should appear below the Jurisdiction dropdown with generic placeholder text.
Author Checklist:
yarn generate:clientand/or created a migration when required