Skip to content

Fix: Remove unused parameter from RelayQueueEngine #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/groups/mqb/mqbblp/mqbblp_relayqueueengine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1802,7 +1802,7 @@ RelayQueueEngine::push(mqbi::StorageMessageAttributes* attributes,
ordinalPlusOne = 1 + app->ordinal();
subscriptions.begin()->setId(ordinalPlusOne);

storePush(attributes, msgGUID, appData, subscriptions, true);
storePush(attributes, msgGUID, appData, subscriptions);

// Attempt to deliver
processAppRedelivery(subQueueId, app);
Expand Down Expand Up @@ -1886,7 +1886,7 @@ RelayQueueEngine::push(mqbi::StorageMessageAttributes* attributes,
if (count) {
// Pass correct ref count
attributes->setRefCount(count);
storePush(attributes, msgGUID, appData, subscriptions, false);
storePush(attributes, msgGUID, appData, subscriptions);
}
return count;
}
Expand Down Expand Up @@ -1927,8 +1927,7 @@ void RelayQueueEngine::storePush(
mqbi::StorageMessageAttributes* attributes,
const bmqt::MessageGUID& msgGUID,
const bsl::shared_ptr<bdlbb::Blob>& appData,
const bmqp::Protocol::SubQueueInfosArray& subscriptions,
bool isOutOfOrder)
const bmqp::Protocol::SubQueueInfosArray& subscriptions)
{
if (d_queueState_p->domain()->cluster()->isRemote()) {
// Save the message along with the subIds in the storage. Note that
Expand Down
3 changes: 1 addition & 2 deletions src/groups/mqb/mqbblp/mqbblp_relayqueueengine.h
Original file line number Diff line number Diff line change
Expand Up @@ -350,8 +350,7 @@ class RelayQueueEngine BSLS_KEYWORD_FINAL : public mqbi::QueueEngine {
void storePush(mqbi::StorageMessageAttributes* attributes,
const bmqt::MessageGUID& msgGUID,
const bsl::shared_ptr<bdlbb::Blob>& appData,
const bmqp::Protocol::SubQueueInfosArray& subscriptions,
bool isOutOfOrder);
const bmqp::Protocol::SubQueueInfosArray& subscriptions);

void beforeOneAppRemoved(unsigned int upstreamSubQueueId);

Expand Down
Loading