Fix: Remove unused parameter from RelayQueueEngine
#681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pniedzielski
force-pushed
the
fix/out-of-order-push-argument
branch
from
e616419 to
36b92f6
Compare
During the fixes relating to monolithic storage, we left an unused parameter in `RelayQueueEngine::storePush` originally denoting whether the push was out-of-order or not. This is no longer needed, so this patch removes the parameter. Signed-off-by: Patrick M. Niedzielski <[email protected]>
pniedzielski
force-pushed
the
fix/out-of-order-push-argument
branch
from
36b92f6 to
924ba24
Compare
|
@dorjesinpo this is low priority, but I don't want it to get lost |
dorjesinpo
reviewed
Apr 10, 2025
There was a problem hiding this comment.
This looks good. My only concern, there is some possibility of using isOutOfOrder in the last step(s) of Reliable Broadcast. So, we have a choice of removing this and then we need to remove the corresponding if clause in RelayQueueEngine, or keeping this for a while
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the fixes relating to monolithic storage, we left an unused parameter in
RelayQueueEngine::storePushoriginally denoting whether the push was out-of-order or not. This is no longer needed, so this patch removes the parameter.Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.