Build and publish Docker images#257
Closed
TheAssassin wants to merge 7 commits intoblue-nebula:masterfrom
Closed
Conversation
voidanix
requested changes
Apr 15, 2023
Member
voidanix
left a comment
There was a problem hiding this comment.
Just a few nits (and questions), otherwise looks good.
The final image is around 150M in size, which is totally reasonable. Most of the size is added by the maps.
Member
Author
|
I managed to remove the patch by introducing a new server variable called |
Member
Author
|
Tested this new variable in production now, works just the way it's meant to work. |
voidanix
reviewed
Apr 28, 2023
Member
Author
|
Closing in favor of #272. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/TheAssassin/base/pkgs/container/bn-server for a demo. The images are fully working and optimized for size.
For now, we will only have a moving target tag called
master(and possibly others for other branches) for public use. Once we create a tag, we'll have a similarly named tag pushed to the registry as well.The
Dockerfileand the docker-compose config were written from scratch. The remaining scripting comes from https://github.com/TheAssassin/redeclipse-docker/.Note that we do not have any documentation on how to use these. We should document how you can dump the
servinit.cfgtemplate so as a user, you can see which variables are available.Edit: to run the most basic server locally, use the following command:
> docker run --rm -it -p 28801:28801/udp -p 28802:28802/udp ghcr.io/theassassin/bn-server:master