Add serverpublicip variable and auto-publish Docker images#272
Merged
Add serverpublicip variable and auto-publish Docker images#272
Conversation
TheAssassin
force-pushed
the
serverpublicip
branch
from
d56dde6 to
8404885
Compare
Member
Author
|
I also had to fix the remaining builds and made a few other adjustments. Please review. |
TheAssassin
force-pushed
the
serverpublicip
branch
2 times, most recently
from
6e00c8b to
40ff667
Compare
voidanix
requested changes
Dec 7, 2025
Member
voidanix
left a comment
voidanix
left a comment
There was a problem hiding this comment.
Commits would need to be cleaned up if possible: only one nit, otherwise the rest looks good
TheAssassin
force-pushed
the
serverpublicip
branch
2 times, most recently
from
ce73b13 to
8cc6d37
Compare
TheAssassin
force-pushed
the
serverpublicip
branch
from
8cc6d37 to
ef7ae89
Compare
The final image is around 150M in size, which is totally reasonable. Most of the size is added by the maps.
TheAssassin
force-pushed
the
serverpublicip
branch
from
ef7ae89 to
80fa3c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successor of #257