Fix TransitionChangeHandlers getting stuck when two are run simultaneously#547
Merged
EricKuck merged 2 commits intobluelinelabs:developfrom Aug 11, 2019
Merged
Conversation
Member
|
This is a really clever fix, nice work! I've tested this with several different scenarios and they all seem to work great. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #545 and the failing test cases in #546.
This takes a defensive approach against the Transition API which, according to its docs, won't run a transition if another transition has already been added for the same scene root in the same frame. It checks to see if the transition has been started by the next frame, and if it hasn't, immediately runs the changes.