Skip to content

Fix TransitionChangeHandlers getting stuck when two are run simultaneously #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EricKuck merged 2 commits into from
Aug 11, 2019
Merged

Fix TransitionChangeHandlers getting stuck when two are run simultaneously #547

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65652d1
Fix TransitionChangeHandlers getting stuck when two are run simultane…
DSteve595 Jun 18, 2019
703c7b5
Don't unnecessarily re-execute changes
DSteve595 Aug 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...uctor/src/main/java/com/bluelinelabs/conductor/changehandler/TransitionChangeHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,19 @@ public void performChange(@NonNull final ViewGroup container, @Nullable final Vi
return;
}

final Runnable onTransitionNotStarted = new Runnable() {
@Override
public void run() {
changeListener.onChangeCompleted();
}
};

final Transition transition = getTransition(container, from, to, isPush);
transition.addListener(new TransitionListener() {
@Override
public void onTransitionStart(Transition transition) { }
public void onTransitionStart(Transition transition) {
container.removeCallbacks(onTransitionNotStarted);
}

@Override
public void onTransitionEnd(Transition transition) {
Expand All @@ -97,6 +106,7 @@ public void onPrepared() {
if (!canceled) {
TransitionManager.beginDelayedTransition(container, transition);
executePropertyChanges(container, from, to, transition, isPush);
container.post(onTransitionNotStarted);
}
}
});
Expand Down