Video store rules all

[rafaellehmkuhl]

With this patch, the video store begins being responsible for internally routing available video streams.

Screen.Recording.2023-12-15.at.17.59.36.mov

Instead of having each video stream consumer (e.g.: VideoPlayer, MiniVideoRecorder) taking full control of the stream it is consuming, we delegate that to the video store, with the widget solely requesting (to the store) the stream it needs. The video store them checks if the requested stream is already being consumed, and if so, routes the same stream, instead of opening a new one with the WebRTC server, which was causing unnecessary usage of both bandwidth and computer resources, to the point of causing system failures or video stuttering.

In resume, with this patch one can add as many widgets as it wants for a same stream and only one connecting will be made to consume it.

I explicitly followed a non-reactive interval-based approach, as I'm not fully confident on the reactive behavior of the WebRTC composable yet. I think we still have an opportunity in the future to improve this code, making it completely reactive, but as it is the performance footprint is very small, and we benefit from having this patch sooner, fixing a critical problem being experienced by our beta testers.

Fix #360
Fix #602
Helps #633.

PS:

[joaoantoniocardoso]

Tested, the only thing I found was this:

1. From the first start after clearing the browser store, the video is showing up, but it is not showing the stream name (there are 2 h264 stream available):

[rafaellehmkuhl]

Tested, the only thing I found was this:

1. From the first start after clearing the browser store, the video is showing up, but it is not showing the stream name (there are 2 h264 stream available):

Good catch!

[rafaellehmkuhl]

Tested, the only thing I found was this:

1. From the first start after clearing the browser store, the video is showing up, but it is not showing the stream name (there are 2 h264 stream available):

Fixed.

[joaoantoniocardoso]

I forgot to test the recording widget stuff. I'll make the review tomorrow =)

[rafaellehmkuhl]

Thanks for the quick approval @patrickelectric! I will only wait to see if there's something from @joaoantoniocardoso before we merge it.

@ES-Alexander I'm going to merge it without the docs changes as it's a critical bug fix and the changes on docs are small.

[joaoantoniocardoso]

Tested. All seems fine!

It also helps #633, fixing the error "2".