-
Notifications
You must be signed in to change notification settings - Fork 87
BLD/STY: migrate to pyproject.toml and ruff #1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@tacaswell so apparently I discovered - with my surprise - that flake8 doesn't support PEP 518. If it's ok with you I would want to merge this and then work on a new PR to swap flake8 with ruff. I could do this in the same PR if you're ok with it. |
|
Can you fix the linting one way or another in this PR? I do want to merge this PR and then have every other PR be broken until we get the lining fixed. I'm 👍 on switching to ruff, flake8 is not a reasonably maintained project. |
|
The simplest thing is probably to drop the flake8 config in what ever file it wants and then remove it in a follow on PR. |
- future PR will remove it entirely and move to ruff instead
|
I dropped flake8 from the |
|
I do not think turning off linting is the best option. It will mean that PRs that come in between this being merged and the linting being fixed will not be linted which means some changes that will flag it will creep in (for example my love of single quotes). Depending on sequencing this may lead to the CI on the commit changing the linter passing and then the main branch failing as soon as it is merged. Can you please either move the flake8 config to someplace it will find it or move to ruff in this PR? |
|
@tacaswell if I remember correctly, ruff default configuration is the same as black, so the same rules for isort should apply as well. |
Tested build locally with
tox -e pytest.Many tests fail on my machine but I suspect this is due to the absence of the CI settings.
EDIT: since flake8 doesn't support PEP 518, this PR also substitutes black and flake8 with ruff