Skip to content

Refactor auth #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 14, 2025
Merged

Refactor auth #891

merged 19 commits into from
Mar 14, 2025

Conversation

DiamondJoseph
Copy link
Contributor

@DiamondJoseph DiamondJoseph commented Feb 19, 2025

This is a PR to pick apart the changes required before #877 into more managably reviewable commits.
This is a step towards closing #887

Checklist

  • Add a Changelog entry
  • Add the ticket number which this PR closes to the comment section

@DiamondJoseph DiamondJoseph force-pushed the refactor-auth branch 4 times, most recently from 3f3b98f to 5dc6dcc Compare February 19, 2025 14:10
Copy link
Member

@danielballan danielballan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass. Echoing my comments on Slack, I love this. It's great to have another pair of eyes on this.

@DiamondJoseph DiamondJoseph marked this pull request as ready for review March 12, 2025 15:31
@danielballan danielballan merged commit a0d9104 into main Mar 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants