Skip to content

test: add core WeakSet builtin unit tests #4912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrhapile wants to merge 3 commits into from
Closed

test: add core WeakSet builtin unit tests #4912

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
092324f
test: add core WeakSet builtin unit tests
mrhapile Mar 7, 2026
31c0751
implemented copilot suggestion
mrhapile Mar 7, 2026
a7f9a82
Merge branch 'main' into test/weakset-core-tests
mrhapile Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/engine/src/builtins/weak_set/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,3 +253,6 @@ impl WeakSet {
Ok(set.contains_key(value.inner()).into())
}
}

#[cfg(test)]
mod tests;
Comment thread
mrhapile marked this conversation as resolved.
27 changes: 27 additions & 0 deletions core/engine/src/builtins/weak_set/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
use crate::{TestAction, run_test_actions};

#[test]
fn weakset_add_and_has() {
run_test_actions([
TestAction::run("var ws = new WeakSet(); var obj = {}; ws.add(obj);"),
TestAction::assert("ws.has(obj)"),
]);
}

#[test]
fn weakset_add_chaining() {
run_test_actions([
TestAction::run("var ws = new WeakSet(); var obj = {};"),
TestAction::assert("ws.add(obj) === ws"),
]);
}

#[test]
fn weakset_delete_behavior() {
run_test_actions([
TestAction::run("var ws = new WeakSet(); var obj = {}; ws.add(obj);"),
TestAction::assert("ws.delete(obj) === true"),
TestAction::assert("ws.delete(obj) === false"),
TestAction::assert("ws.has(obj) === false"),
]);
}
Loading