Skip to content

Ensure enforce.sh doesn't use unset variables #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2025
Merged

Conversation

Flamefire
Copy link
Collaborator

Test this by using set -u in build scripts

@Flamefire Flamefire mentioned this pull request Feb 28, 2025
@Flamefire Flamefire force-pushed the enforce-set-u branch 5 times, most recently from 978b17f to 916a526 Compare February 28, 2025 15:41
@Flamefire Flamefire requested a review from sdarwin February 28, 2025 15:46
Test this by using `set -u` in build scripts
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e415c67) to head (79aa619).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           22        22           
  Branches        12        12           
=========================================
  Hits            22        22           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e415c67...79aa619. Read the comment docs.

@Flamefire
Copy link
Collaborator Author

@sdarwin All looks good now on CI. Can you do a last check and merge this please? Then you should be able to rebase your lcov branch on top and enable set -u which would be a good test for this too

@sdarwin
Copy link
Collaborator

sdarwin commented Mar 2, 2025

  • Rebased into lcov branch.
  • In terms of merging to master: if you are very confident about set -u for all boost repos using these CI files, then in that case I approve the PR, you may merge.

@Flamefire Flamefire merged commit 605750a into master Mar 2, 2025
67 checks passed
@Flamefire Flamefire deleted the enforce-set-u branch March 2, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants