Fix clang-cl MSVC frontend received GNU flag on assembling
#294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marakew can you copy patch to your |
|
seems works |
Challanger524
force-pushed
the
fix_clang-cl_masm_combo
branch
from
5f6f4b5 to
628cefe
Compare
|
@olk how about merge ? |
|
ty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #293
Put
if (GNU/Clang)into the MASM'selseclause sinceClang-CLvalidates positive atCMAKE_CXX_COMPILER_ID STREQUAL "Clang"while also havingMSVCfrontend for compile options and utilisingMLmasm assembler.UPD:
clang-cl/quietsupport has been dropped due to inability to know real version for sure.Side (weird) fix for
/quietflag being passed onMSVC_VERSION: 1936despite Visual Studio Enterprise 2019 Version 16.11.35:Dropping context
message(STATUS "MSVC_VERSION: ${MSVC_VERSION}")=-- MSVC_VERSION: 1936report/quietSuppresses 'Assembling' message. Available in Visual Studio 17.6 and later.Looks like CMake gives wrong
MSVC_VERSIONforclang-cl.Tested
On MS Windows with CMake with next compilers:
MSVC, msys2/mingw64/GCC, msys2/clang64/Clang,Clang-CL(chocolatey install)