Edit required check so that it doesn't hang when only non-code files modified#2024
Merged
Edit required check so that it doesn't hang when only non-code files modified#2024
Conversation
Member
Author
|
Whoops, I got the required check wrong. I thought it was Linux CI; it's Python CI. I will fix that. |
Member
Author
|
Now it's right. Alternatively, the required check could just be turned off (or just require a PR before merging instead of a PR + check), and this PR can be rejected. @dellaert up to you |
dellaert
approved these changes
Feb 16, 2025
Member
dellaert
left a comment
dellaert
left a comment
There was a problem hiding this comment.
Cool, I’ll merge and we’ll see…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue encountered in #2023 where the check required by the repository rule (Linux CI) does not run when only Markdown files are edited, but it's still "required," so it blocks the PR from being merged because GitHub just waits for the check to run, but it never does.
Works by running a preliminary job to see if relevant files were modified, and only runs the main job if they were.
The other checks can keep the simpler
paths-ignoresyntax because they are not required under a ruleset.