Cleanup eigen svd clang warning. Update svd options usage.#2032
Closed
jmackay2 wants to merge 1 commit intoborglab:developfrom
Closed
Cleanup eigen svd clang warning. Update svd options usage.#2032jmackay2 wants to merge 1 commit intoborglab:developfrom
jmackay2 wants to merge 1 commit intoborglab:developfrom
Conversation
Member
|
Cool! but still some Ci issue :-) |
Member
|
BTW, this might be an issue:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the GCC diagnostic handling for svd by checking the svd info. This was made available in Eigen 3.4, which this repository uses.
This also updates a few of the JacobiSVD to use the templated options. This is the preferred method instead of passing it in as an argument, which will be deprecated in the future.