Move scripts for building wheels to CI directory#2044
Merged
varunagrawal merged 2 commits intodevelopfrom Mar 10, 2025
Merged
Conversation
yambati03
approved these changes
Mar 9, 2025
Contributor
yambati03
left a comment
yambati03
left a comment
There was a problem hiding this comment.
This looks good to me! I originally had them in a top-level build_tools directory since it seemed like the common practice across other large open source projects such as scikit-learn and numpy. However, I can see this being confusing and moving them to the .github/scripts folder makes it clear that these are associated with the Github Actions workflow. Thanks!
Contributor
Author
|
Got it! That actually makes a lot of sense if we were a python oriented codebase. Thanks for the information. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we use CMake for building GTSAM, most users will have a build directory, and this may cause confusion with the newly added
build_toolsdirectory.This PR moves the
cibuildwheelscripts to.github/scripts/python_wheelsso that everything is nicely packaged under a single directory tree (which is.github).@yambati03 you may have had some good design choices when creating
build_tools, which I would really like to understand. 🙂