Conversation
|
@p-zach let me know when you have incorporated notes from our meeting |
|
I have made all of the simple notebook changes. I will get the changes involving .i file modifications pushed once I finish them asap. |
|
Resolved remaining issues:
|
|
Awesome. The |
dellaert
left a comment
There was a problem hiding this comment.
Overall the quality of the docs is astoundingly good! I left some comments but it’s a bit hard to review on GitHub. We could look over the other notebooks in our meeting, that’s probably easier. The labeledSymbol and roles comments can be left for another PR.
Thanks for this excellent PR!
|
Modified according to comments (less ord & roles). Will merge after CI |
New docs for
inferenceWorkflow
The way I generated these (there is room for improvement/more efficiency, although considering the amount done, it was quick work):
inferencefolder compressed by repomix to xml to Gemini 2.5 Pro Preview 03-25; uploadPose2.ipynbfromgeometry; prompt: "I already have a notebook describing Pose2, see below. Using that notebook as an example, could you produce notebooks for the classes in inference? One notebook per class."nonlinear.md, and copy that output toinference.md.myst.ymlto include the new files.Issues
There are several problems which are currently causing errors in the code cells:
.roots()for anyBayesTreeimplementation is exposedEliminationTreeimplementation is exposedGaussianISAMdoesn't have print or copy constructor exposedOrdering.Colamd(variableIndex)seems to overwriteOrdering.Colamd(graph); you have to manually convert it likeOrdering.Colamd(VariableIndex(graph))LabeledSymbol(char, char, int)constructor is not exposedOrdering.invertis not exposedtype object 'gtsam.gtsam.Ordering' has no attribute 'ColamdConstrainedLast'even though it seems likeColamdConstrainedLastis exposed. Not sure why.VariableIndex[x]is not exposedI will leave this as a draft PR until these problems are resolved.