Add support for building MacOS wheels in cibuildwheel#2093
Merged
yambati03 merged 3 commits intoborglab:developfrom Apr 17, 2025
Merged
Add support for building MacOS wheels in cibuildwheel#2093yambati03 merged 3 commits intoborglab:developfrom
cibuildwheel#2093yambati03 merged 3 commits intoborglab:developfrom
Conversation
dellaert
approved these changes
Apr 17, 2025
Member
dellaert
left a comment
dellaert
left a comment
There was a problem hiding this comment.
Very cool!!! Could you add to the PR comment how you know it works? I will then approve and merge.
Member
|
Oops I already approved. So, merge at will but after you added (for tracking sake) how you now it works and why you are sure it will work in CI :-) |
Contributor
Author
|
I |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for in
cibuildwheelfor generating Python wheels for MacOS 10.15+.How was this tested?
The wheel generated from a test run of the updated
cibuildwheelwaspip installed-ed on a laptop running MacOS 14.6. We then ran the following example https://github.com/borglab/gtsam/blob/develop/python/gtsam/examples/ImuFactorExample.py, which functioned as expected.We also note that all builds ran successfully in a forked repository, and wheel files were generated for each OS + Python version pair.
