Merged
Conversation
Member
|
Sure, wrap FrobeniusPrior and everything else :-) |
Member
Author
|
Decided in meeting that I will resolve KarcherMean and PoseRotationPrior issues; @dellaert will look into LAGO and PlanarProjectionFactor issues. I will also fix any typographical errors and wrap all the unwrapped functions. |
Member
|
Sorry @p-zach I accidentally fixed KarcherMeanFactor. Hope you have not already done it also. |
Fixed KarcherMean, LAGO, PlanarProjectionFactor
… new-docs-slam
Member
Author
|
Fixed most of the notebooks' problems. Remaining issues
|
Member
Remaining issues
Fixed by adding to values.i
Fixed by using typedefs in SimpleCamera.h
Wrapping works but type mismatch in notebook is still an issue |
Member
Author
|
@dellaert Great! I was wrestling with RigFactor too, glad you figured it out. All good to merge after CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New docs for the SLAM directory.
Current issues: