Skip to content

New docs: SLAM#2111

Merged
dellaert merged 20 commits intodevelopfrom
new-docs-slam
Apr 27, 2025
Merged

New docs: SLAM#2111
dellaert merged 20 commits intodevelopfrom
new-docs-slam

Conversation

@p-zach
Copy link
Copy Markdown
Member

@p-zach p-zach commented Apr 24, 2025

New docs for the SLAM directory.

Current issues:

  • FrobeniusFactor seems to need FrobeniusPrior. Wrap it?
  • KarcherMeanFactor doesn't know how to use JacobianFactor
  • LAGO: invalid map
  • OrientedPlane not wrapped
  • PlanarProjectionFactor: weird type error
  • PoseRotationPrior: not sure why import isn't working
  • PoseTranslationPrior: same as RotationPrior
  • ReferenceFrameFactor: not wrapped
  • RotateFactor: not wrapped
  • SmartFactorParams: just needs a couple functions wrapped
  • SmartProjectionFactor: not wrapped
  • SmartProjectionPoseFactor: not wrapped
  • SmartProjectionRigFactor: not wrapped
  • StereoFactor: Cal3S2_Stereo.backproject not wrapped

@p-zach p-zach requested a review from dellaert April 24, 2025 15:02
@dellaert
Copy link
Copy Markdown
Member

Sure, wrap FrobeniusPrior and everything else :-)

@p-zach
Copy link
Copy Markdown
Member Author

p-zach commented Apr 24, 2025

Decided in meeting that I will resolve KarcherMean and PoseRotationPrior issues; @dellaert will look into LAGO and PlanarProjectionFactor issues. I will also fix any typographical errors and wrap all the unwrapped functions.

@dellaert
Copy link
Copy Markdown
Member

Sorry @p-zach I accidentally fixed KarcherMeanFactor. Hope you have not already done it also.

@p-zach
Copy link
Copy Markdown
Member Author

p-zach commented Apr 27, 2025

Fixed most of the notebooks' problems.

Remaining issues

  • OrientedPlane3Factor.ipynb
    • OrientedPlane3 does not act like a Value, so it can't be added to Values, etc.
  • ReferenceFrameFactor.ipynb
    • Templating issues. I think I should be able to fix these tomorrow.
  • SmartProjectionFactor.ipynb, SmartProjectionRigFactor.ipynb
    • These have the same problem, which stems from an issue with wrap (Improper template expansion wrap#175). In short, their add functions aren't wrapped properly because some of the parameters are based on typedefs within the double-templated class (double-templated meaning like SmartProjectionFactor<PinholeCamera<Cal3_S2>>). In this case, it's PinholeCamera's Measurement/MeasurementVector. I have not yet found a solution to this.

@dellaert
Copy link
Copy Markdown
Member

dellaert commented Apr 27, 2025

Remaining issues

  • OrientedPlane3Factor.ipynb

Fixed by adding to values.i

  • SmartProjectionFactor.ipynb

Fixed by using typedefs in SimpleCamera.h

SmartProjectionRigFactor.ipynb

Wrapping works but type mismatch in notebook is still an issue

Copy link
Copy Markdown
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing effort ! Smart factors was harder than anticipated.
I think there are no more issues, so approving now. Let me know if not the case @p-zach .

@p-zach
Copy link
Copy Markdown
Member Author

p-zach commented Apr 27, 2025

@dellaert Great! I was wrestling with RigFactor too, glad you figured it out. All good to merge after CI

@dellaert dellaert merged commit 42cc0ac into develop Apr 27, 2025
36 checks passed
@dellaert dellaert deleted the new-docs-slam branch April 27, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants