Conversation
Member
dellaert
commented
May 7, 2025
- added SmartFactors.md, which gives detailed math and implementation details for smart factors
- RegularHessianFactor: Format, document, optimize slightly - Gemini 2.5
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds detailed documentation for smart factors including mathematical derivations and implementation details as well as several formatting, documentation, and optimization improvements for the RegularHessianFactor class. Key changes include:
- Adding the SmartFactors.md file with comprehensive math details and usage examples.
- Updating the Colab URL in the EKF_SLAM notebook to reflect the correct repository structure.
- Enhancing documentation, error messaging, and optimizations in RegularHessianFactor.h.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| python/gtsam/examples/EKF_SLAM.ipynb | Updated the Colab badge URL to point to the correct file location. |
| gtsam/slam/doc/SmartFactors.md | New documentation file detailing the mathematics and implementation of smart factors. |
| gtsam/linear/RegularHessianFactor.h | Refactored and documented methods with performance optimizations and enhanced error messages. |
Comments suppressed due to low confidence (1)
python/gtsam/examples/EKF_SLAM.ipynb:33
- Ensure that the updated URL accurately reflects the repository structure and intended location.
<a href="https://colab.research.google.com/github/borglab/gtsam/blob/develop/python/gtsam/examples/EKF_SLAM.ipynb" target="_parent"><img src="https://colab.research.google.com/assets/colab-badge.svg" alt="Open In Colab"/></a>
Member
Author
|
Merging without review as functionality-neutral |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.