Skip to content

Pull in newest GeographicLib (2.5)#2128

Closed
dellaert wants to merge 6 commits intodevelopfrom
feature/bumpGeographicLib
Closed

Pull in newest GeographicLib (2.5)#2128
dellaert wants to merge 6 commits intodevelopfrom
feature/bumpGeographicLib

Conversation

@dellaert
Copy link
Copy Markdown
Member

@dellaert dellaert commented May 7, 2025

Just swapped in newest source distribution.

@jlblancoc and @JaiXJM-BB , their cmake changed a bit, so don;t know how to fix include install dir as in:
903e7de
Comment with your opinion?

@dellaert dellaert requested a review from jlblancoc May 7, 2025 21:47
@dellaert dellaert changed the base branch from develop to feature/smartFactorDocs May 8, 2025 12:43
Base automatically changed from feature/smartFactorDocs to develop May 8, 2025 17:09
@dellaert dellaert requested a review from ProfFan May 12, 2025 15:51
@dellaert
Copy link
Copy Markdown
Member Author

So, I tried something, with help from gemini. Seems to work.

PS, an alternative is to fully remove GeographicLib. It's vendored in (and adds complexity) for basically three tests and was only used in a side project, so we could take the stance that - if you need it, install it.

@dellaert
Copy link
Copy Markdown
Member Author

Actually, windows still does not work. Unless I get feedback on why to keep it, I will go with the “remove” option tomorrow. Will save 11MB in cloning, as well.

@jlblancoc
Copy link
Copy Markdown
Member

I can't see the error in Windows CI, only cancelled pipelines (?).

But anyway, if it's not needed by any core functionality, it's probably easier to "let it go" as vendored in; as years go by, I get more and more convinced that we should try to keep libraries as simple as possible... 🤔

@dellaert
Copy link
Copy Markdown
Member Author

Thanks @jlblancoc - I think I will do just that. It will save 11MB as well.

@dellaert dellaert closed this May 13, 2025
@dellaert dellaert deleted the feature/bumpGeographicLib branch December 26, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants