Closed
Conversation
varunagrawal
added
bugfix
Member
|
Varun, thank you for this! But I think the fix is just |
Contributor
Author
|
Sure thing. Feel free to cherry pick the pertinent commits. I have one just for adding the include, and others for formatting, so it should be very simple. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also formatted the LieEKF, ManifoldEKF and InEKF files to follow GTSAM's Google clang-format style.
Additionally, I renamed
GEKF_Rot3ExampletoIEKF_Rot3Exampleto match the file docstring.Fixes #2133