Merged
Conversation
varunagrawal
approved these changes
May 16, 2025
Contributor
varunagrawal
left a comment
varunagrawal
left a comment
There was a problem hiding this comment.
LGTM though I'm a bit skeptical about the include location. It's for a trait in the LieEKF class so shouldn't it belong there?
Member
Author
No. It’s for a trait used in the template instantiation, in the example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2133
also updated cmake version to allow for most recent cmake to work. Not yet an issue on CI it seems but will be soon.