Skip to content

Add Multi RobotKeyFormatter as an external variable (Windows)#2140

Merged
dellaert merged 1 commit intoborglab:developfrom
DrWisdome:formatter-export
May 18, 2025
Merged

Add Multi RobotKeyFormatter as an external variable (Windows)#2140
dellaert merged 1 commit intoborglab:developfrom
DrWisdome:formatter-export

Conversation

@DrWisdome
Copy link
Copy Markdown

This PR is a fix for Windows users, just like the default formatter was exported, MultiRobotKeyFormatter also needs to be exported in order to compile correctly.

P.S.: I would like to thank you prof. Frank Dellaert and your group, your work is a treasure.

- static const gtsam::KeyFormatter MultiRobotKeyFormatter = &_multirobotKeyFormatter;
+ extern GTSAM_EXPORT KeyFormatter MultiRobotKeyFormatter; 

Copy link
Copy Markdown
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dellaert dellaert merged commit e2d3cf5 into borglab:develop May 18, 2025
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants