Conversation
Fixes incorrect header being included, which also broke C++11 compatibility.
4.2: Fix an invalid include, restore C++11 compatibility
…trackgenerator Cherrypick commits for release/4.2, that include transitivity fix for DsfTrackGenerator
Adds jacobians to translation() and rotation() for Pose2 to bring it into spec with Pose3's equilivent functions. Also adds tests.
# Conflicts: # .github/workflows/build-special.yml # CMakeLists.txt # README.md # cmake/HandleGeneralOptions.cmake # cmake/HandlePrintConfiguration.cmake # examples/Pose3Localization.cpp # examples/SolverComparer.cpp # gtsam/base/SymmetricBlockMatrix.h # gtsam/discrete/DecisionTree.h # gtsam/discrete/DiscreteFactorGraph.h # gtsam/discrete/DiscreteJunctionTree.h # gtsam/discrete/DiscreteValues.h # gtsam/discrete/discrete.i # gtsam/discrete/tests/testDecisionTreeFactor.cpp # gtsam/discrete/tests/testDiscreteBayesTree.cpp # gtsam/geometry/Pose3.cpp # gtsam/geometry/Pose3.h # gtsam/geometry/geometry.i # gtsam/hybrid/HybridGaussianFactorGraph.cpp # gtsam/hybrid/HybridNonlinearFactorGraph.cpp # gtsam/hybrid/HybridSmoother.cpp # gtsam/hybrid/HybridValues.h # gtsam/hybrid/hybrid.i # gtsam/hybrid/tests/testGaussianMixtureFactor.cpp # gtsam/hybrid/tests/testHybridGaussianFactorGraph.cpp # gtsam/inference/BayesTreeCliqueBase.h # gtsam/linear/NoiseModel.cpp # gtsam/linear/linear.i # gtsam/nonlinear/Expression-inl.h # gtsam/nonlinear/Values-inl.h # gtsam/nonlinear/Values.cpp # gtsam/nonlinear/Values.h # gtsam/nonlinear/tests/testValues.cpp # gtsam/sfm/ShonanAveraging.h # gtsam/slam/tests/testLago.cpp # gtsam/symbolic/symbolic.i # gtsam_unstable/examples/SmartRangeExample_plaza1.cpp # gtsam_unstable/examples/SmartRangeExample_plaza2.cpp # gtsam_unstable/nonlinear/BatchFixedLagSmoother.h # package.xml # python/gtsam/tests/test_DiscreteBayesTree.py # python/gtsam/tests/test_DsfTrackGenerator.py # tests/testGaussianISAM2.cpp # timing/timeCameraExpression.cpp # timing/timeLago.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge in changes made in release branch a long time ago