Ported StereoVOExample_large and Edits to StereoVOExample#2195
Ported StereoVOExample_large and Edits to StereoVOExample#2195dellaert merged 11 commits intoborglab:developfrom
Conversation
dellaert
left a comment
There was a problem hiding this comment.
Very cool, some comments, and some that we discussed in person
0f502d5 to
e70b8f8
Compare
|
Still some things that we discussed that are not there (separate parsing from adding to FG), and plotting, but I'll assume you're still working on this. Just request a re-review via Github when this is ready. |
|
@dellaert Everything should be ready now! Update(s):
|
|
Very cool! Please make sure both notebooks are restarted and you have "run all"? I can't merge until this is done, as there will be no outputs on website. |
|
@dellaert I did a quick check and ran all again, and all cells that outputs something should now have an output. As a side note, I also checked the notebooks by viewing them on Github, and I noticed that the plotly figures didn't render; I'm pretty sure this is an issue with Github because the figures render correctly on my local deployment of the MyST site and I can see the pyplot data in the output when I view the notebook as a text file. So, everything should be all good! |
Ported the C++ StereoVOExample_large to a Python Notebook. The new notebook example is functionally the same as the C++ example with some additional explanation spread throughout.
Update(s):
StereoVOExample.ipynbCheck(s):
make checkpasses all tests.