Skip to content

Ported StereoVOExample_large and Edits to StereoVOExample#2195

Merged
dellaert merged 11 commits intoborglab:developfrom
CodeXTL:port/StereoVOExample_large
Jul 15, 2025
Merged

Ported StereoVOExample_large and Edits to StereoVOExample#2195
dellaert merged 11 commits intoborglab:developfrom
CodeXTL:port/StereoVOExample_large

Conversation

@CodeXTL
Copy link
Copy Markdown
Contributor

@CodeXTL CodeXTL commented Jul 9, 2025

Ported the C++ StereoVOExample_large to a Python Notebook. The new notebook example is functionally the same as the C++ example with some additional explanation spread throughout.

Update(s):

  • The main difference is that data files are downloaded from the GTSAM Github rather than creating another data folder just for the Python examples. This also makes the notebook easier to use in Colab.
  • Also made some minor changes to StereoVOExample.ipynb

Check(s):

  • Checked the results of the C++ example and the newly ported notebook example, and they match
  • Running make check passes all tests.

Copy link
Copy Markdown
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, some comments, and some that we discussed in person

@CodeXTL CodeXTL force-pushed the port/StereoVOExample_large branch from 0f502d5 to e70b8f8 Compare July 10, 2025 03:13
@dellaert
Copy link
Copy Markdown
Member

Still some things that we discussed that are not there (separate parsing from adding to FG), and plotting, but I'll assume you're still working on this. Just request a re-review via Github when this is ready.

@CodeXTL
Copy link
Copy Markdown
Contributor Author

CodeXTL commented Jul 12, 2025

@dellaert Everything should be ready now!

Update(s):

  • Added cell tags so unnecessary cells (copy right, Colab env check) are not rendered by MyST.
  • Shifted Google Colab button to be right under the main title
  • StereoVOExample_large.ipynb specific changes:
    • Made large revision to StereoVOExample_large to have more comprehensive explanation
    • Separated code for parsing and adding to FG
    • Added plotting to visually analyze the end result using Plotly
  • StereoVOExample.ipynb specific changes
    • Minor updates/polishes to explanation

@dellaert
Copy link
Copy Markdown
Member

Very cool! Please make sure both notebooks are restarted and you have "run all"? I can't merge until this is done, as there will be no outputs on website.

@CodeXTL
Copy link
Copy Markdown
Contributor Author

CodeXTL commented Jul 15, 2025

@dellaert I did a quick check and ran all again, and all cells that outputs something should now have an output. As a side note, I also checked the notebooks by viewing them on Github, and I noticed that the plotly figures didn't render; I'm pretty sure this is an issue with Github because the figures render correctly on my local deployment of the MyST site and I can see the pyplot data in the output when I view the notebook as a text file. So, everything should be all good!

@dellaert dellaert merged commit 1530c9b into borglab:develop Jul 15, 2025
9 checks passed
@CodeXTL CodeXTL deleted the port/StereoVOExample_large branch July 16, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants