Skip to content

Add vcpkg compilation with gtsam in INSTALL.md doc#2269

Merged
dellaert merged 1 commit intoborglab:developfrom
talregev:TalR/vcpkg_doc
Oct 10, 2025
Merged

Add vcpkg compilation with gtsam in INSTALL.md doc#2269
dellaert merged 1 commit intoborglab:developfrom
talregev:TalR/vcpkg_doc

Conversation

@talregev
Copy link
Copy Markdown
Contributor

@talregev talregev commented Oct 4, 2025

Add vcpkg section in INSTALL.md doc.
Explain how to compile gtsam with vcpkg

@dellaert
As for your request, I added a section in INSTALL.md doc that compile gtsam with vcpkg.
commands taken from CI and adapt for linux/wsl in local.

@talregev talregev force-pushed the TalR/vcpkg_doc branch 4 times, most recently from 09a8ba2 to aea75d8 Compare October 4, 2025 14:19
@dellaert
Copy link
Copy Markdown
Member

dellaert commented Oct 4, 2025

Ah, maybe I miscommunicated. I do know how to install GTSAM with WSL, it’s basically Linux.
What I meant was maybe a section on vcpkg - which needs to be introduced, and seems to be defined for Mac/linux/windows. I will discuss WSL in the windows section, and then we can mention that as far as vcpkg is concerned, it’s the same as Linux.

@dellaert
Copy link
Copy Markdown
Member

dellaert commented Oct 4, 2025

Also, any comments on #2268 ?

@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Oct 4, 2025

This section is explain how to install gtsam with vcpkg library on wsl / linux. Not with linux/wsl libraries.
for mac and windows there should be many small changes across this section.
You don't have to accept this PR, you can take it as a template and change it as you see fit.
Basically you have all the commands written on the CI.

I just notice #2268. Thank you for let me know. I will comment there also.

Copy link
Copy Markdown
Contributor

@Gold856 Gold856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove --config Release. You've selected the Ninja generator, which isn't a multi-config generator, so --config Release is useless.

@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Oct 5, 2025

Remove --config Release. You've selected the Ninja generator, which isn't a multi-config generator, so --config Release is useless.

For Visual Studio (msvc) is a multi-generator, we need to use --config.
I removed the --config, but please add it when you explain how to compile in windows.

@Gold856
Copy link
Copy Markdown
Contributor

Gold856 commented Oct 5, 2025

You're conflating the compiler with the build system. The Visual Studio generator (MSBuild) is not the same thing as MSVC. We are using the Ninja generator with the MSVC compiler, which means --config is completely ignored. If you do not pass -G Ninja, CMake will instead default to the Visual Studio 17 2022 generator, which is a multi-config generator, where --config can be used to select a build type.

@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Oct 5, 2025

On the windows section we need to explain that we remove the --config because of the Ninja. Ninja is a single-config generator.
If user choose to compile windows gtsam without the Ninja generator it must bring back the --config.

@dellaert dellaert merged commit 33df753 into borglab:develop Oct 10, 2025
3 checks passed
@talregev talregev deleted the TalR/vcpkg_doc branch October 10, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants