Replace FastVector custom allocator with std::vector default allocator#2283
Closed
Replace FastVector custom allocator with std::vector default allocator#2283
Conversation
Co-authored-by: ProfFan <5358374+ProfFan@users.noreply.github.com>
Co-authored-by: ProfFan <5358374+ProfFan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace FastVector implementation with normal vector and custom allocator
Replace FastVector custom allocator with std::vector default allocator
Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the
FastVectorimplementation by replacing the custom allocator configuration with the standardstd::vectordefault allocator, while maintaining full backward compatibility.Problem
Previously,
FastVectorwas implemented as:This required:
FastDefaultAllocator.hGTSAM_ALLOCATOR_TBBdefineSolution
Simplified
FastVectorto:This change:
FastDefaultAllocator.hChanges
Modified:
gtsam/base/FastVector.hFastDefaultAllocator.hincludeImpact
FastVector<T>throughout the codebase continue to work without modificationCustom Allocator Support
Users who need custom allocators can now use them explicitly:
Migration
No migration needed - all existing code continues to work as-is. The
FastVectortype alias is maintained for backward compatibility.Testing
All core tests pass:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.