Conversation
|
Cool. Please merge in develop so we can run CI. |
I am always rebase to dev ;) |
|
I also noticed that vcpkg for windows takes forever. Anything that can be done about that? |
dellaert
left a comment
There was a problem hiding this comment.
Looks good. Any comments on MKL and OpenMP performance?
I am not sure, maybe we should leave this PR for more people comments on it. |
It should be faster on intel cpu. I never test it. |
I can run it again after it finished without changes and see if the sccache helps reduce building time |
|
I will put here the time: I am not sure also why macos is taking so long, because it don't compile mkl. The changes I did make this build time to increase? |
|
I will run it again to test the sccache |
|
I will put the time here after run the CI without changes: If you approve it, it mean that it will take 2.5h for windows for every big change. Not sure how much is today. |
Add vcpkg mkl. For windows and linux. intel stop support mkl for osx.
I change tests and other files because it had compilation errors on mkl with eigen3 v5.x, Similar errors we had with eigen3 v5.x PR.
I let the AI fix these errors. Please review these correction and verify that they are correct.