Fix Eigen issue in PseudorangeFactor#2380
Merged
Conversation
This is why I don't trust AI
dellaert
approved these changes
Feb 1, 2026
Contributor
Author
|
How did you merge that? The Windows CI was still running so it wouldn't let me merge. :/ |
Contributor
|
Thanks @varunagrawal for catching this and submitting a hotfix quickly! I’ll keep this in mind for future contributions. |
Member
Not required per branch protection rules |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilation with GCC 14 fails due to a small issue with setting
Hreceiver_clock_bias.The issue is that Eigen's matrix initialization can trigger SSE-based operations on small matrices, and GCC 14's bounds checker flags this as unsafe, resulting in a warning which our CMake config treats as an error.
cc @masoug for future reference.