Introducing DifferentialPseudorangeFactor#2383
Conversation
|
Thank you for the contributions!
I would recommend splitting out the common stuff as standalone utility functions instead of inheritance
I think you can put things in
|
There was a problem hiding this comment.
Very nice. Your factor graph illustration is also great, but maybe it would be more clear if you showed the correction and the pseudo factors for two satellites. You really have to read the text to understand that there one correction variable per satellite.
Also wondering what happens over time and as the receiver moves.
|
Yes, I walked in them (Coyote) hills. There used to be nuclear missiles stationed there, too 🚀 |
|
I don't think putting code in I have used |
|
Agreed. @masoug, please put that module in the examples folder, next to the notebooks, and do the wget on colab. |
|
Thanks for the feedback! I'll get these comments addressed in the next couple days 👍 |
8e69411 to
0184cae
Compare
I've updated the illustration by adding an image (I couldn't get mermaid render a decent graph) showing two satellites and their pseudorange factors. Attached is an updated notebook output: DifferentialPseudorangeExample.html
This is a great question! Spoiler alert: Position quality degrades over long times and great distances between the user and reference stations. I wanted to run an experiment where I plot accuracy as a function of distance-from-reference-station for a variety of test station across CORS, but I'd put that in a separate notebook not designed for documentation/tutorial. |
dellaert
left a comment
There was a problem hiding this comment.
Awesome ! cool new graphic :-)
0184cae to
0287893
Compare
Hello again! I've experimented with applying differential corrections to the
PseudorangeFactorand found ~98% accuracy improvement. I've attached a copy of my experiments here: DifferentialPseudorangeExample.htmlSimilar to before, I'm seeking feedback on:
PseudorangeFactorandDifferentialPseudorangeFactor? So far I went with simple inheritance, but if there's a more elegant way to arrange the classes, let me know!gnss_utils.pyto de-duplicate a lot of repetition, so I'm wondering if that's okay for the two pseudorange examples.gnss_utils.pycause issues with google colab?DifferentialPseudorangeExample.ipynb; what could be clarified, and what are some suggestions to communicate the significance of going from 30->0.4 meter accuracy? Does anyone know of good geospatial map plotting libraries that work well with Jupyter? ChatGPT suggested folium...Anyway, I'm interested to hear what y'all think 🧠 I think I might look at carrier-phase factors next, so @varunagrawal I'd be interested in learning more about your experiences on that, if you're willing to share 🙏
Best,
Sammy